Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basically every electronic device can now be used by the AI. #31730

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 1, 2024

About the PR

Made most if not all electronic devices be usable by AI.

Why / Balance

AI was meant to be able to interact with every electronic. This PR basically ensures of that. (With minor exceptions)

Technical details

Modified yaml files for most electronic items.
That includes:
Dispensers:
Booze
Chem
Soda

Arcades: (Have AI wires)
Space Villain
Block Game

Power/Generation:
AME Controller

Machines:
Vending Machines (Have AI wires)
Salvage Magnet
Reagent Grinder
Microwave
Jukebox (Has AI wire)
Gravity Generator
Mini Gravity Generator
Flatpacker
Fax Machine
Captain Fax Machine
ChemMaster
A.P.E
Anomaly Generator (Has AI wire)
Electrolysis Unit
Cryopod

Computers:
ID Computer
IFF Computer
Alerts Computer
R&D Computer
Analysis Console
Body Scanner Console
Cargo Request Computer
Cargo Bounty Computer
Cargo Sale Computer
Cloning Console Computer
Communications Computer
Crew Monitoring Console
Criminal Records Computer
Mass Scanner Computer
Medical Records Computer
Power Monitoring Computer
Station Records Computer
Solar Control Console
Salvage Expedition Console
Robotics Console
Tech Disk Terminal

Doors:
Firelocks (No bolt UI)
High Sec Doors (Has AI wire)

Shuttles:
Station Anchor (not indestructible)

Piping/Disposal:
Disposal Unit
Mailing Unit

Wallmounts:
Air Alarm (Has AI wire)

Piping/Atmos:
Pressure Gas Pump
Volumetric Gas Pump
Signal Valve
Space Heater
Gas Filter
Gas Mixer
Freezer
Heater
Hellfire Freezer
Hellfire Heater

Media

None. Don't know what to show here.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 ScarKy0

  • add: A lot more electronics can now be used by the AI.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 1, 2024
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

Exceptions: Shuttle consoles(their UI doesnt work), news console(doesnt work) and most electronics that would allow a complete destruction of the station.

@lzk228
Copy link
Contributor

lzk228 commented Sep 1, 2024

gives ai too much power
i'm still of the opinion that AI access should be limited to machines with an AI wire

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 1, 2024

gives ai too much power
i'm still of the opinion that AI access should be limited to machines with an AI wire

I agree, but by design AI is to have access to all electronics.
If I knew how to make a machine have AI wires I absolutely wouldve done it

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 1, 2024
@Nimfar11
Copy link
Contributor

Nimfar11 commented Sep 2, 2024

It seems AI shouldn't have a direct way to control equipment, only through consoles. I mean Piping/Atmos.
AME Controller also seems superfluous here.

@metalgearsloth
Copy link
Contributor

Rather than bikeshedding every one list needs stripping down, also stuff like the A.P.E shouldn't be useable by AI.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 2, 2024

Rather than bikeshedding every one list needs stripping down, also stuff like the A.P.E shouldn't be useable by AI.

What stuff should I take out? Ill update it next chance I get

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 2, 2024

I mean Piping/Atmos.
AME Controller also seems superfluous here.

Removed AME controller, but in ss13 AI could control atmos just fine, ill remove it if a maintainer asks though

@Nimfar11
Copy link
Contributor

Nimfar11 commented Sep 2, 2024

Removed AME controller, but in ss13 AI could control atmos just fine, ill remove it if a maintainer asks though

Did this happen under direct control, or through the console? It seems to me that even in ss13 the AI could not do this, perhaps through a signal pump.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 2, 2024

Did this happen under direct control, or through the console? It seems to me that even in ss13 the AI could not do this, perhaps through a signal pump.

Direct control, unless its malf only

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 2, 2024

Added AI wires to arcades, vending machines, jukeboxes, anomaly gen, high security doors, secure doors and air alarms

@slarticodefast
Copy link
Member

Could you remove pumps, filters, mixers and valves from the whitelist as these are not digital devices? The signal valve can stay as an exception.

@slarticodefast slarticodefast added the S: Awaiting Changes Status: Changes are required before another review can happen label Sep 5, 2024
@lzk228
Copy link
Contributor

lzk228 commented Sep 5, 2024

not digital devices

in that case would be logical to remove buttons aswell

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 5, 2024

Could you remove pumps, filters, mixers and valves from the whitelist as these are not digital devices? The signal valve can stay as an exception.

Will take care of it after I wake up

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 5, 2024

Done, so basically ready for merge I believe

@slarticodefast
Copy link
Member

Thank you for your contribution!

@slarticodefast slarticodefast merged commit 83eac64 into space-wizards:master Sep 5, 2024
11 checks passed
@ScarKy0 ScarKy0 deleted the more-AI-interactions branch September 5, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Awaiting Changes Status: Changes are required before another review can happen S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants