Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AI Actions #31823

Merged

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 4, 2024

About the PR

My other PR needs to get merged before this one #31799

AI Actions now work correctly.(Mass Scanner. Crew Monitor, Criminal Records)
Gave AI a Comms console.

Why / Balance

Bugfixes mostly but also AI had comms in ss13.

Technical details

Added missing components to the AI that allow it to use the monitors.

Media

First image unrelated.
image
image
image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changed all shuttles to transmit their timer over Wireless instead of Private.
Screens now take info from the Wireless netId.

Changelog

for non-players: aghost's comms console now has a functional broadcast button.
🆑

  • fix: AI Actions now work.

@ScarKy0 ScarKy0 requested a review from DrSmugleaf as a code owner September 4, 2024 06:27
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

RSI Diff Bot; head commit 26877be merging into 8a06dde
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/actions_ai.rsi

State Old New Status
ai_core Modified
camera_light Modified
crew_monitor Modified
state_laws Modified
comms_console Added
job_view Added
mass_scanner Added
station_records Added

Edit: diff updated after 26877be

@ScarKy0 ScarKy0 changed the title Ai has a comms console in hud Fixed AI Actions + Comms Console Sep 4, 2024
@ScarKy0 ScarKy0 marked this pull request as draft September 4, 2024 06:29
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 4, 2024

TODO: Figure out why AGhost and AI cannot broadcast via their comms consoles

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 4, 2024

TODO: Figure out why AGhost and AI cannot broadcast via their comms consoles

Figured it out but im gonna pause work until other stuff gets merged in first

@ScarKy0 ScarKy0 force-pushed the AI-has-a-comms-console-in-HUD branch from 47a88e0 to 26877be Compare September 4, 2024 18:34
@github-actions github-actions bot added the Changes: Map Changes: Might require knowledge of mapping. label Sep 4, 2024
@ScarKy0 ScarKy0 changed the title Fixed AI Actions + Comms Console Fixed AI Actions Sep 4, 2024
@ScarKy0 ScarKy0 marked this pull request as ready for review September 4, 2024 18:42
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 4, 2024

Figured it out but im gonna pause work until other stuff gets merged in first

I lied

@UbaserB
Copy link
Member

UbaserB commented Sep 4, 2024

so based!

@ScarKy0 ScarKy0 mentioned this pull request Sep 4, 2024
2 tasks
Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you actually intended it to but this doesn't actually do anything with the actions and doesn't fix their UIs.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 5, 2024

I'm not sure if you actually intended it to but this doesn't actually do anything with the actions and doesn't fix their UIs.

This fixes that the consoles in the UI dont display any data when opened

@metalgearsloth metalgearsloth merged commit ecc38ad into space-wizards:master Sep 5, 2024
25 checks passed
@ScarKy0 ScarKy0 deleted the AI-has-a-comms-console-in-HUD branch September 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants