Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaceshroom grilling #31872

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

goet
Copy link
Contributor

@goet goet commented Sep 5, 2024

About the PR

Changes spaceshroom cooking to be temperature based instead of the microwave timer. They can now be cooked both in the microwave and on the grill.

Why / Balance

There is a maints room in cog that features a grill with spaceshrooms on top of it, urging the player to cook them. This was impossible before.
/
The cooked item is identical to the previous recipe and it roughly takes the same amount of time to cook. It's possible to cook them in batches, but this shouldn't be a problem as they provide the same amount of nutrients as steaks.

Media

grillin.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • tweak: Spaceshrooms can now be cooked on the electric grill.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 5, 2024
@Emisse Emisse requested a review from TheShuEd September 6, 2024 23:24
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 6, 2024
@UbaserB
Copy link
Member

UbaserB commented Sep 7, 2024

what's the purpose of the fixture?

@goet
Copy link
Contributor Author

goet commented Sep 7, 2024

what's the purpose of the fixture?

It's required for InternalTemperature to work. Without it, the heat capacity of the entity will be so high the internal temp barely moves despite the surface temperature being 100+ more. You can still walk over it and throwing doesn't feel different so I don't think it's affecting anything else, but I could be wrong on this.

Basically without the fixture this will return over 50 (no idea where it gets the FixtureMass from):

return comp.SpecificHeat * physics.FixturesMass;

Which in here will make the delta temp practically 0:
var degrees = joules / GetHeatCapacity(uid, temp);

Values are just copied from the steak, it ended up cooking for the correct time with the temp so I didn't change it.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Service Area: Service department, including cooking, botany, etc size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 21, 2024
@SlamBamActionman SlamBamActionman merged commit db69ae6 into space-wizards:master Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants