Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor Crafting Change #31966

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

TheWaffleJesus
Copy link
Contributor

About the PR

changes how you use capacitors while crafting (basically just makes stacks of them be useable without it eating it all)
(also sorry if this is a bandaid fix or this bricks someones pc)

Why / Balance

so that you dont use up a whole stack while crafting, or need to split for medsec hud.

Technical details

adds a sprite/icon to capacitors in the stack file, and changes them from being tags or whatever to material instead in a crafting recipe (works with stacks!! yippeee!!)

Media

image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • fix: You can now craft items with stacks of capacitors without it eating it all!

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 8, 2024
@chromiumboy
Copy link
Contributor

Looks good, works as advertised

@chromiumboy chromiumboy added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Nov 13, 2024
@chromiumboy chromiumboy self-assigned this Nov 13, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SaphireLattice SaphireLattice added T: Bugfix Type: Bugs and/or bugfixes P1: High Priority: Higher priority than other items, but isn't an emergency. D2: Medium Difficulty: A good amount of codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. A: General Interactions Area: General in-game interactions that don't relate to another area. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 16, 2024
@SaphireLattice
Copy link
Contributor

Does this still work if you have two loose capacitors around?

@SaphireLattice SaphireLattice added S: Needs Review Status: Requires additional reviews before being fully accepted and removed A: Core Tech Area: Underlying core tech for the game and the Github repository. labels Nov 16, 2024
@TheWaffleJesus
Copy link
Contributor Author

TheWaffleJesus commented Nov 18, 2024

Does this still work if you have two loose capacitors around?

doesn't seem so, but it seems that's the case for other items that need a stack (like crafting artifacts with fragments, baseball bat, bananium horn, blindfold and so on)

@metalgearsloth metalgearsloth merged commit 59b0938 into space-wizards:master Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants