Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds salvage magnet board to the circuit imprinter #31996

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

ArtisticRoomba
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba commented Sep 9, 2024

About the PR

Adds the salvage magnet board to the circuit imprinter (available roundstart), and to QM's locker.

Why / Balance

The salvage magnet board is currently unable to be obtained IC. You either have to admeme it into existence or simply suffer, as the salvage gameplay loop literally cannot be started with the magnet missing.

If your salvage magnet gets emogarbaged (meteored), stolen, or otherwise obliterated it can now be easily repaired. This PR fixes #31994.

I don't think this should be under research, science partially relies on Cargo for their gameplay loop and it would just be a happier situation if this could be made roundstart, it's a pretty integral thing for salvage.

The recipe requires gold for the circuitboard but the RD can easily ransack the vault for some gold if necessary. If this needs to be changed (because RD somehow spent all the station's gold on useless shit) let me know. Same with the technology thing.

Reminder of the TODO: Make the salvage magnet require HV wire and draw a lot of power when active, to mechanically enforce having the magnet being the "starter" for salvage's gameloop. Would require map changes.

Technical details

YAML editing lmao.
Adds SalvageMagnetMachineCircuitboard to electronics.yml
Adds SalvageMagnetMachineCircuitboard to lathe.yml under staticRecipes if you're having a really bad day.
Adds the supply sprite component to the circuitboard.

Media

Media shows changed sprite, components needed, the double salvage magnet situation staying consistent, and the flatpacked version of the magnet.

Content Client_ebl7ZHmT4s

Requirements

Breaking changes

Changelog

🆑

  • tweak: The salvage magnet circuitboard has been added to QM's locker. It can also be made at the circuit imprinter roundstart. NOW GET BACK TO WORK!!!

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 9, 2024
@Cojoke-dot
Copy link
Contributor

Just add it to the qm's closet, else sci salv would be too prevalent. It would just replace the spare reclaimer shuttle board anyways.

@ArtisticRoomba
Copy link
Contributor Author

Sure.

@lzk228
Copy link
Contributor

lzk228 commented Sep 9, 2024

to resolve the issue i would just made salv magnet not completely desctruclible but turned into "broken" version that can be repaired

@Cojoke-dot
Copy link
Contributor

to resolve the issue i would just made salv magnet not completely desctruclible but turned into "broken" version that can be repaired

meh, meteors would end up just knocking it off the grid into deep space then

@ArtisticRoomba
Copy link
Contributor Author

yeah, meteors can just knock it out into deep space, and with the magnet being so integral to salv's gameloop, it would be better to have this be on a lathe + in locker

if we feel that it needs to be behind technology then I can add it to a salvage-related tech that makes sense

@lzk228
Copy link
Contributor

lzk228 commented Sep 9, 2024

i'm just afraid that salv will abuse two or even three magnets
or it's not possible?

@ArtisticRoomba
Copy link
Contributor Author

not possible as stated and demonstrated in the PR, linked issue, and screenshot.

@lzk228
Copy link
Contributor

lzk228 commented Sep 9, 2024

that's fine then

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 9, 2024
@ArtisticRoomba
Copy link
Contributor Author

What

@ArtisticRoomba
Copy link
Contributor Author

Oh, #31524 lmao
Now I don't have to worry about random mats pricing

# Conflicts:
#	Resources/Prototypes/Recipes/Lathes/electronics.yml
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 10, 2024
@ArtisticRoomba
Copy link
Contributor Author

also @deltanedas related issue to your PR #31524 while we're here, the base protos for BaseGoldCircuitboardRecipe and BaseCircuitboardRecipe show despite abstract: true in the lathe
Content Client_CfAyLjFJid

@deltanedas
Copy link
Contributor

oh abstract wasnt inherited big funny :trollface:

@beck-thompson
Copy link
Contributor

Just had a shift where a meteorite exploded our magnet... Not fun we just sat around for the rest of the shift!

@Emisse
Copy link
Contributor

Emisse commented Sep 10, 2024

shure

@Emisse Emisse merged commit b306afb into space-wizards:master Sep 10, 2024
11 checks passed
@ArtisticRoomba ArtisticRoomba deleted the salvage-magnet-board branch December 10, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Way To Get A New Salvage Magnet IC
8 participants