Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make laid power cables more visible v2 #32008

Merged
merged 4 commits into from
Sep 9, 2024
Merged

make laid power cables more visible v2 #32008

merged 4 commits into from
Sep 9, 2024

Conversation

qwerltaz
Copy link
Contributor

@qwerltaz qwerltaz commented Sep 9, 2024

About the PR

Another approach to cable offsetting for better visibility. Fixes issue added by and discussed in #32000.

Media

2024-09-09_377_Content Client

and more importantly, before and after

image

Requirements

Breaking changes

n

Changelog

already had cl I guess

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

RSI Diff Bot; head commit 1eb11a9 merging into 3b2fc54
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Power/Cables/hv_cable.rsi

State Old New Status
hvcable_0 Modified
hvcable_1 Modified
hvcable_10 Modified
hvcable_11 Modified
hvcable_12 Modified
hvcable_13 Modified
hvcable_14 Modified
hvcable_15 Modified
hvcable_2 Modified
hvcable_3 Modified
hvcable_4 Modified
hvcable_5 Modified
hvcable_6 Modified
hvcable_7 Modified
hvcable_8 Modified
hvcable_9 Modified

Resources/Textures/Structures/Power/Cables/lv_cable.rsi

State Old New Status
lvcable_0 Modified
lvcable_1 Modified
lvcable_10 Modified
lvcable_11 Modified
lvcable_12 Modified
lvcable_13 Modified
lvcable_14 Modified
lvcable_15 Modified
lvcable_2 Modified
lvcable_3 Modified
lvcable_4 Modified
lvcable_5 Modified
lvcable_6 Modified
lvcable_7 Modified
lvcable_8 Modified
lvcable_9 Modified

Resources/Textures/Structures/Power/Cables/mv_cable.rsi

State Old New Status
mvcable_0 Modified
mvcable_1 Modified
mvcable_10 Modified
mvcable_11 Modified
mvcable_12 Modified
mvcable_13 Modified
mvcable_14 Modified
mvcable_15 Modified
mvcable_2 Modified
mvcable_3 Modified
mvcable_4 Modified
mvcable_5 Modified
mvcable_6 Modified
mvcable_7 Modified
mvcable_8 Modified
mvcable_9 Modified

@Everturning
Copy link

window issue fixed?

@qwerltaz
Copy link
Contributor Author

qwerltaz commented Sep 9, 2024

window issue fixed?

The sprites now have no way of clipping outside now so probably fixed.

@Emisse Emisse merged commit f9faafe into space-wizards:master Sep 9, 2024
14 checks passed
@qwerltaz qwerltaz deleted the cable-sprite-offset branch September 9, 2024 19:21
@slarticodefast slarticodefast mentioned this pull request Sep 9, 2024
Closed
de0rix pushed a commit to de0rix/space-station-14 that referenced this pull request Sep 11, 2024
@qwerltaz
make laid power cables more visible v2 (space-wizards#32008)
d3fd31f 
* Revert "make cables more visible"

This reverts commit b2defdf.

* offset cable sprite

* :-)

* one more pixel for mv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerltaz @Everturning @Emisse