Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a ton of contraband issues #32078

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

Plykiya
Copy link
Contributor

@Plykiya Plykiya commented Sep 11, 2024

About the PR

  • combat gloves are security/engi restricted AGAIN
  • helmets are not security restricted by default (do not give base entities contraband statuses for the love of god)
  • cult helmet is major contraband (evil ass shit)
  • space ninja helmet is major contraband (evil ass shit)
  • atmos fire helmet is engi restricted
  • ling helmet is major contraband (lings are evil as shit)
  • few helmets were made minor contraband
  • justice helmet is security restricted
  • hos gas mask is security restricted
  • ert gas mask is centcomm restricted
  • cult, changling, bone, and ironclad armor are major contraband (they're webvest tiers of strong), also gives them suit storage slots as all armor should have
  • comms computer is a grand theft target
  • syndicate comms computer is syndicate contraband
  • centcomm pen is centcomm restricted

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 11, 2024
@Everturning
Copy link

doesnt make sense to make items contraband just because they're strong. why would bone armor be contraband in-universe? same for ironclad armor?
also, I don't think the communications board is grand theft if an engi can get it from tech vault on some stations

@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 11, 2024

doesnt make sense to make items contraband just because they're strong. why would bone armor be contraband in-universe? same for ironclad armor? also, I don't think the communications board is grand theft if an engi can get it from tech vault on some stations

if you want a better reasoning
cults (acolyte armor) are super illegal and changelings are antagonists on par with ninjas

how I was told it was distinguished was
minor contraband = improvised weaponry (shivs, bats) and armor (makeshift shields, that kind of thing)
major contraband = REAL weaponry (katanas, whatever that meme musket is, other guns) and armor

@Everturning
Copy link

I can get the cult and ninja and ling stuff but the bone and ironclad armor is what im confused about, why would something that's just strong but not restricted to a department be major contraband?

@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 11, 2024

I can get the cult and ninja and ling stuff but the bone and ironclad armor is what im confused about, why would something that's just strong but not restricted to a department be major contraband?

real bones had to be used for the bone armor (illegal to debone crew without cmo/RD permission i would imagine)

even if it wasn't made by some maint dweller it was probably stolen from ashwalkers and stealing cultural artifacts is probably illegal

@slarticodefast slarticodefast merged commit e140b3f into space-wizards:master Sep 12, 2024
11 checks passed
@Plykiya Plykiya deleted the contraband-fixes branch September 12, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants