Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job title localization #32338

Merged

Conversation

chavonadelal
Copy link
Contributor

@chavonadelal chavonadelal commented Sep 20, 2024

About the PR

localizing job title. Replaced all uses of JobTitle with LocalizedJobTitle.

Fixes #28791

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

🆑 to4no_fix

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 20, 2024
@beck-thompson
Copy link
Contributor

Strongest localization warrior 💪 💪 💪

@chavonadelal
Copy link
Contributor Author

Strongest localization warrior 💪 💪 💪

Start your day with game localization! 🥤

@chavonadelal
Copy link
Contributor Author

Everything is fixed and working

@lzk228
Copy link
Contributor

lzk228 commented Sep 21, 2024

fixes #28791

@SlamBamActionman SlamBamActionman self-assigned this Oct 7, 2024
Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests good. Needs another maintainer's approval to merge, as according to the review guidelines.

@VasilisThePikachu VasilisThePikachu merged commit 6d99597 into space-wizards:master Oct 9, 2024
11 checks passed
@chavonadelal chavonadelal deleted the job-title-localization branch October 9, 2024 15:11
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 9, 2025
* Job title localization

* Correcting fields
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
* Job title localization

* Correcting fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobTitle field in IdCardComponent should support locale strings
5 participants