Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Koi #32378

Closed
wants to merge 2 commits into from
Closed

Space Koi #32378

wants to merge 2 commits into from

Conversation

AlokenMaloken
Copy link

About the PR

Added a friendly version of the carps - space koi. You can buy crate with them in cargo or meet near spawner.

Why / Balance

A little friendly fauna in an unfriendly outer space. They drop only regular meat, so you'll still have to hunt carps for toxin and teeth.

Technical details

Media

Screenshot_68
Screenshot_69

2024-09-22.21-54-25.-.Trim.-.Trim.1.mp4

Requirements

Breaking changes

Changelog
🆑

  • add: Added friendly animal Space Koi in 5 colors.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 22, 2024
Copy link
Contributor

github-actions bot commented Sep 22, 2024

RSI Diff Bot; head commit d57326c merging into b78156a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Aliens/Kois/blood_skeleton.rsi

State Old New Status
alive Added
dead Added
icon Added

Resources/Textures/Mobs/Aliens/Kois/gold_black.rsi

State Old New Status
alive Added
dead Added
icon Added

Resources/Textures/Mobs/Aliens/Kois/red_black.rsi

State Old New Status
alive Added
dead Added
icon Added
livestock_icon Added

Resources/Textures/Mobs/Aliens/Kois/red_circle.rsi

State Old New Status
alive Added
dead Added
icon Added

Resources/Textures/Mobs/Aliens/Kois/space_glow.rsi

State Old New Status
alive Added
dead Added
icon Added
unshaded Added

Edit: diff updated after d57326c

@K-Dynamic
Copy link
Contributor

Could you also add them to the biocube fabricator

Resources/Prototypes/Recipes/Lathes/rehydrateable.yml

@thebadman4662
Copy link

Dammit, got baited. Thought we are getting space Koibeans

@UbaserB UbaserB added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 22, 2024
@Spessmann
Copy link
Contributor

Spessmann commented Sep 22, 2024

Are they space in the same way other space animals are? As in, don't require air & dont take spacing damage etc?

Also, is there a spawner for them?

@AlokenMaloken
Copy link
Author

Are they space in the same way other space animals are? As in, don't require air & dont take spacing damage etc?

Also, is there a spawner for them?

Yup

@Everturning
Copy link

can you make them give fish meat (NOT carp filet) maybe for sushi addition later

@AlokenMaloken
Copy link
Author

can you make them give fish meat (NOT carp filet) maybe for sushi addition later

I can, but there's no fish meat in game yet, so I'll have to make it myself and shouldn't sushi have poisoning chance?

@slarticodefast
Copy link
Member

Yeah, if you can simply order friendly carp gaining carpotoxin for cognizine would be way too easy.
Otherwise I really like how they look.

@AlokenMaloken
Copy link
Author

AlokenMaloken commented Sep 22, 2024

Yeah, if you can simply order friendly carp gaining carpotoxin for cognizine would be way too easy. Otherwise I really like how they look.

They drop only regular meat, so you won't be able to get carpotoxin

@nymhole
Copy link

nymhole commented Sep 23, 2024

do the crates always come with the same 5 fish?

@nymhole
Copy link

nymhole commented Sep 23, 2024

shouldn't sushi have poisoning chance?

it should rot

@AlokenMaloken
Copy link
Author

do the crates always come with the same 5 fish?

Yeah, 5 koi in all colors

@YehatRebel
Copy link

I like the friendly space fish. I hope to see them in the game alongside more aquatic creatures.

@AlokenMaloken
Copy link
Author

@UbaserB So, any news on maintainers discussion? It's been 1,5 months now

@UbaserB
Copy link
Member

UbaserB commented Nov 5, 2024

Sorry for the late response, this PR kind of got lost when we switched over our PR review system.
Thank you for the contribution, but the general consensus is to close this PR for two reasons;

  1. It's bloat currently, with no reason for an entity like this to exist (see "new pets freeze" in Current Freezes and PR restrictions #8524)
  2. We'd rather wait for the carp migration event from ss13 to add koi into the game

@UbaserB UbaserB closed this Nov 5, 2024
@AlokenMaloken AlokenMaloken deleted the space-koi branch November 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants