Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grey trenchcoat for detective loadout #32380

Conversation

LittleNorthStar
Copy link
Contributor

@LittleNorthStar LittleNorthStar commented Sep 22, 2024

About the PR

adds the Noir trenchcoat to the detective loadout page, to match the availability of the hat and jumpsuit

Why / Balance

the Noir trenchcoat unlike Noir jumpsuit and hat are not available in the loadout page

Technical details

made changes to coats.yml to add detective trenchcoat default contents (I'm not certain this was necessary?), and edited detectives.yml and loadout_groups.yml to add Noir Trenchcoat

Media

Screenshot 2024-09-23 003243

Requirements

Breaking changes

Changelog

🆑

  • add: Noir trenchcoat to detective loadout

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 22, 2024
@Everturning
Copy link

Yesssss

@lzk228
Copy link
Contributor

lzk228 commented Sep 22, 2024

and it goes right in #8524!

@UbaserB
Copy link
Member

UbaserB commented Sep 22, 2024

and it goes right in #8524!

no it doesnt, the freeze is for new clothing not adding existing clothing to loadouts

@lzk228
Copy link
Contributor

lzk228 commented Sep 22, 2024

oh

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 23, 2024
@slarticodefast
Copy link
Member

Looks good to merge to me. Could you add the changelog entry to your PR description? The bot automatically uses that to generate the in-game changelog and your name will get added to the game's credits. It should already be there in the template, you only have to uncomment it.

@LittleNorthStar
Copy link
Contributor Author

Looks good to merge to me. Could you add the changelog entry to your PR description? The bot automatically uses that to generate the in-game changelog and your name will get added to the game's credits. It should already be there in the template, you only have to uncomment it.

Just fixed the changelog and one of the Xs I noticed was a bit weird

@slarticodefast
Copy link
Member

Just fixed the changelog and one of the Xs I noticed was a bit weird

Your changelog is still broken, it needs the 🆑 emoji and the right formatting or the bot won't read it. Have a look at the PR guidelines to see how to do it.

@LittleNorthStar
Copy link
Contributor Author

Just fixed the changelog and one of the Xs I noticed was a bit weird

Your changelog is still broken, it needs the 🆑 emoji and the right formatting or the bot won't read it. Have a look at the PR guidelines to see how to do it.

Sorry this is my first time doing a PR did I get it correct now?

@slarticodefast
Copy link
Member

Looks good to me. Thank your for your contribution and your first PR :)

@slarticodefast slarticodefast merged commit bbf84d0 into space-wizards:master Sep 27, 2024
11 checks passed
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 7, 2024
* Detective grey coat available in loadout

* Revert "Detective grey coat available in loadout"

This reverts commit 3697e15.

* Reapply "Detective grey coat available in loadout"

This reverts commit 8e5f43a.

* Hoping I got this right?

* Fixing a oversight

* Update Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants