-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add planet lighting #32522
base: master
Are you sure you want to change the base?
Add planet lighting #32522
Conversation
…ain datafield replicated. Changes were outlined in the salvage to accommodate the new lighting system.
europa real?? |
# Conflicts: # Content.Server/Parallax/BiomeSystem.cs # Content.Server/Salvage/SpawnSalvageMissionJob.cs # Resources/Prototypes/Procedural/salvage_mods.yml
Should roof tiles block weather too? I know weather is also a bool on the tile. Downstream we made a weather blocking marker because it was less effort than having different variants of tiles. Merging roof and weather bool would cut down some but will still lead to duplicated tiles for indoor outdoor I think. Unless there's a better way to do it like with an entity (like a pillar in the corner that smooths, so the only tell is the corners that they're a roof, and let people construct / deconstruct roofs then). Was a pleasant surprise nontheless. |
It's good to see this hasn't fallen into oblivion! |
I've made roof a flag on tiles themselves though merging it with weather would be better for a separate PR to make cherry-picking easier I think. I still need to fix some planetmap stuff before we would start playtesting it upstream anyway. |
Nice. Preciate the work on it. Would applying the setroof component to entities work too? Just for more dynamic buildings and destruction I'd be leaning that way personally. |
Very nice to see that code getting used after all! |
I could probably remove queuedel from it and it would probably work and just make that a separate component. I can probably remove the lookups from the overlay too in lieu of solely relying on tiles. |
Will stations get day-night lighting too? |
I mean we could do it but at the moment no. |
Might need to have a maints discussion, since the dark of space is used to hide a lot of antag activity, but I think it would be neat to have the solar panels periodically get some actual sun :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool
Just up here to get help with some stuff still a while out.
Requires space-wizards/RobustToolbox#5490
🆑 DoutorWhite & metalgearsloth