Make crew monitor update blips at consistent rates #32555
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
SlamBamActionman
added
the
S: Untriaged
beck-thompson
added
T: Bugfix
chromiumboy
requested changes
Dec 20, 2024
Comment on lines
439
to
440
| else | ||
| { |
There was a problem hiding this comment.
Suggested change
| else | |
| { |
| var worldToMonitor = _transformSystem.GetInvWorldMatrix((EntityUid)NavMap.MapUid); | ||
| var refInMonitor = Vector2.Transform(refPosition, worldToMonitor); | ||
| return new EntityCoordinates((EntityUid)NavMap.MapUid, refInMonitor); | ||
| } |
| @@ -290,7 +291,7 @@ private void PopulateDepartmentList(IEnumerable<SuitSensorStatus> departmentSens | |||
| { | |||
| NavMap.TrackedEntities.TryAdd(sensor.SuitSensorUid, | |||
| new NavMapBlip | |||
| (coordinates.Value, | |||
| (CoordinatesToLocal(coordinates!.Value), | |||
There was a problem hiding this comment.
It's best to avoid null-suppression if possible
chromiumboy
added
the
S: Awaiting Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Made crew monitor update off-grid entities at same rate as on-grid ones. Fixes #30338.
Why / Balance
UI was inconsistently being updated for monitored crew on different grids.
Technical details
Great big comment in the change. Map blips were using EntityCoordinates, so would see changes immediately when the transform of the parent entity changed. Just converts all the blips to use the same, fixed coordinate system.
Media
Peek.2024-09-30.20-42.mp4
Requirements
Breaking changes
Changelog