Fully Revert Clown Waddling #32652
Merged
Fully Revert Clown Waddling #32652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sad day, see space-wizards#29156 for discussion
github-actions
bot
added
the
S: Needs Review
|
1984, but all the clown replays are broken so it makes sense yeah |
|
Yeah, this is necessary, waddling has too many bugs. |
|
as said the original author will not work on this, so waddling will be gone for at least a year before anyone cares enough to rework it all |
should be good now |
slarticodefast
approved these changes
Oct 6, 2024
slarticodefast
added
S: Approved
VasilisThePikachu
approved these changes
Oct 6, 2024
|
In case someone wants to work on a proper reimplementation, some of the requirements are mentioned here: #29156 |
Ilya246
pushed a commit
to Ilya246/space-station-14
that referenced
this pull request
Oct 7, 2024
Fully revert Clown Waddling (revival of space-wizards#29161) A sad day, see space-wizards#29156 for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fully reverts waddling, revival of #29161
Why / Balance
Requested by Sloth here and further approved of here. A couple other people in the discord, including a game admin, also requested this.
The original PR was closed by the creator deleting their head repository, not by any consensus.
Waddling as implemented is entirely broken, the original creator is no longer working on SS14, and it needs reimplementing according to Sloth's reviews (something entirely above my skill level). I am sad to see it go, but as-is it makes the game look and feel worse as a clown.
Technical details
Reverts #26338, #26965, #26983, and #27628
Media
Requirements
Breaking Changes
Removed:
WaddleAnimationSystem
WaddleWhenWornComponent
WaddleClothingSystem
WaddleAnimationComponent
SharedWaddleAnimationSystem
Changelog
🆑