Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper capitalisation for supervisors when entering the game #32683

Merged

Conversation

averystarbits
Copy link
Contributor

@averystarbits averystarbits commented Oct 7, 2024

About the PR

Changed job-supervisors.ftl to inclue proper capitalisation.

Why / Balance

It just really pissed me off to look at.
image

Technical details

Edited
job-supervisors-$role/department = the head of department to -> Head of Department

Media

image
to
image

Requirements

Breaking changes

N/A

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Oct 7, 2024
@slarticodefast slarticodefast self-assigned this Oct 7, 2024
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 7, 2024
@lzk228
Copy link
Contributor

lzk228 commented Oct 7, 2024

such small locale fix doesn't require a changelog

@slarticodefast
Copy link
Member

such small locale fix doesn't require a changelog

Yeah, it doesn't really have any gameplay impact.
Could you remove the changelog from your PR description?

@slarticodefast
Copy link
Member

Also your computer's time settings seem to be really messed up somehow
grafik

@TeenSarlacc
Copy link

Also your computer's time settings seem to be really messed up somehow
grafik

nah they're a timelord

@averystarbits
Copy link
Contributor Author

such small locale fix doesn't require a changelog

Yeah, it doesn't really have any gameplay impact. Could you remove the changelog from your PR description?

sure just woke up

@averystarbits
Copy link
Contributor Author

Also your computer's time settings seem to be really messed up somehow
grafik

nah they're a timelord

because of this comment i will refuse to fix it until i feel like it

@slarticodefast
Copy link
Member

slarticodefast commented Oct 7, 2024

I just hope it doesn't break anything in our repository when we merge any commit from the future

Do you have linux/window dual boot by the way? That often causes this because they use a different hardware clock formats.

@VasilisThePikachu VasilisThePikachu merged commit 0e0887b into space-wizards:master Oct 8, 2024
11 checks passed
@averystarbits
Copy link
Contributor Author

I just hope it doesn't break anything in our repository when we merge any commit from the future

Do you have linux/window dual boot by the way? That often causes this because they use a different hardware clock formats.

Late reply yes I dualboot windows & linux. I've just been too busy to set it up.

@averystarbits averystarbits deleted the hop-enter-typo branch October 16, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants