Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Examine Damage now specifies no damage #33064

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

thetolbean
Copy link
Contributor

@thetolbean thetolbean commented Oct 30, 2024

About the PR

When you examine an item that is a weapon, but has no damage, IE a plushie, it now specifies that it does no damage.
May be paired with a revert of #33061 to once again show plushie 'damage'

Why / Balance

Shows that the examined item is a weapon but does no damage.
Fix #33052 (Second try)

Technical details

Checks the items damage dictionary to check if there is only one damage type and if that damage is 0.
Returns specific "no damage" message

Media

{35C8CA65-FA1E-4592-9019-5508252996CC}

Requirements

Changelog
🆑

  • fix: Items with a damage of 0 now have correct damage examination text.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Oct 30, 2024
@lzk228
Copy link
Contributor

lzk228 commented Oct 30, 2024

yeah, that's what i was trying to do in this system but couldn't figure it out, thanks!
also you might revert the hiding damage from plushies
but it's the thing for discussions, should new players know that plushie can be used as a weapon though without a damage?

@chromiumboy chromiumboy self-assigned this Nov 10, 2024
@chromiumboy chromiumboy added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 10, 2024
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Nov 10, 2024
@thetolbean thetolbean marked this pull request as draft November 10, 2024 21:21
@thetolbean thetolbean marked this pull request as ready for review November 10, 2024 21:21
@chromiumboy chromiumboy added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 11, 2024
@chromiumboy
Copy link
Contributor

Looks good, tested in game fine. Thanks for the fix

@SlamBamActionman SlamBamActionman added T: Bugfix Type: Bugs and/or bugfixes S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed PR: Bug Fix labels Nov 14, 2024
@SaphireLattice SaphireLattice added P1: High Priority: Higher priority than other items, but isn't an emergency. D3: Low Difficulty: Some codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
@metalgearsloth metalgearsloth merged commit 75acce0 into space-wizards:master Nov 20, 2024
22 of 23 checks passed
@thetolbean thetolbean deleted the 0-damage-examine branch November 20, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D3: Low Difficulty: Some codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

damage examine should not be available if the damage is zero
7 participants