Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make kill objectives only target players with jobs #33135

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

make kill objectives only target players with jobs #33135

wants to merge 11 commits into from
+58 −1

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Nov 3, 2024 •
edited
Loading

About the PR

title

Why / Balance

so you dont get objective to kill ert or some admin testing area urist or a nukie

Technical details

  • added MindHasMatchingRole to SharedRoleSystem for looking for roles matching a whitelist
  • added RoleWhitelist and RoleBlacklist fields to PickRandomPersonComponent, unused right now but exists for flexibility
  • added OnlyChoosableJobs that filters targets to anyone with a SetPreference=true job (can be readied up for)
  • made kill objective have onlyChoosableJobs: true

Media

image

Requirements

Breaking changes

Changelog
🆑

  • fix: Fixed non-crew being picked for traitor kill objectives.

@Errant-4
Copy link
Member

Errant-4 commented Nov 3, 2024 •
edited
Loading

ERT, CBURN and Death Squad are now jobs, and will probably still be targeted

@slarticodefast
Copy link
Member

Rarely getting a kill objective for nukies, ninjas, ert and so on is totally a feature in my opinion.

@deltanedas
Copy link
Contributor Author

ERT, CBURN and Death Squad are now jobs, and will probably still be targeted

would checking the job can be readied up for work for these edge cases?

@Errant-4
Copy link
Member

Errant-4 commented Nov 3, 2024

ERT, CBURN and Death Squad are now jobs, and will probably still be targeted

would checking the job can be readied up for work for these edge cases?

Not sure from the top of my head how you would do that/what that would entail

@NoElkaTheGod
Copy link
Contributor

ERT, CBURN and Death Squad are now jobs, and will probably still be targeted

Well, at least they are on station for some time, so it is possible to kill them (although pretty damn hard). Still better than having to kill a ninja, which can stun with one click and outrun anything.

@IProduceWidgets
Copy link
Contributor

Maybe pull from the crew manifest list?

@deltanedas
Copy link
Contributor Author

SetPreference is what im going to use but maybe theres some weird edge cases from that

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Nov 17, 2024
@ScarKy0 ScarKy0 added P1: High Priority: Higher priority than other items, but isn't an emergency. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 17, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 27, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities D2: Medium Difficulty: A good amount of codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deltanedas @Errant-4 @slarticodefast @NoElkaTheGod @IProduceWidgets @SlamBamActionman @ScarKy0