Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds handheld artifact container to cargo orders #33327

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adds handheld artifact container to cargo orders #33327

wants to merge 7 commits into from

Conversation

SpaceRox1244
Copy link
Contributor

About the PR

Adds a handheld version of the artifact container and makes it available for purchase by cargo. The handheld version has the capacity to hold one small artifact and provides all the same containment benefits.

Why / Balance

To provide a practical means of safely transporting artifacts that are small enough to fit in backpacks without it feeling like dragging a big artifact. We have big bulky artifacts and small handheld artifacts, I think we ought to have big bulky containers and small handheld containers.

Technical details

Media

arti container

Requirements

Breaking changes

Changelog

🆑 SpaceRox1244

  • add: Cargo can now order handheld artifact containers for transporting small artifacts.

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

RSI Diff Bot; head commit daaeff5 merging into f75be07
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Storage/artifact_container.rsi

State Old New Status
bounty Added
captain Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
invoice Added
locked Added
paper Added
unlocked Added

Edit: diff updated after daaeff5

@beck-thompson
Copy link
Contributor

The sprite is so cute ❤️

@github-actions github-actions bot added the size/L Denotes a PR that changes 1000-4999 lines. label Nov 15, 2024
@thebadman4662
Copy link

Small artifacfts can increase to ginormous size on container node, so bigger grid with whitelist might be better than 2x2... actually can ginormous things even fit into anything, even bluespace backpacks? 🤔

Something like animal carrier might be better otherwise.

@SaphireLattice SaphireLattice added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Art Area: Art with no implications for other areas. A: Cargo/Salvage Area: Cargo department or Salvage. A: Science Area: Science department, not including Silicons. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Art Area: Art with no implications for other areas. labels Nov 15, 2024
@IProduceWidgets
Copy link
Contributor

I agree should work like animal carrier and also this makes more sense as a science research than a cargo order.

@SpaceRox1244
Copy link
Contributor Author

I agree should work like animal carrier and also this makes more sense as a science research than a cargo order.

It does not make sense as a science research.

@Kadeo64
Copy link
Contributor

Kadeo64 commented Nov 15, 2024

It does not make sense as a science research.

>be department that researches and develops
>research anomalous and dangerous artifacts
>parent company (NT) develops artifact container to contain the anomalous artifacts
>so commonplace it's mapped on nearly every station
>can't reverse-engineer common tech that you have access to to make it smaller
>can create bags of holding and speed boots
>logic

@SaphireLattice SaphireLattice added P3: Standard Priority: Default priority for repository items. and removed P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. labels Nov 15, 2024
@SpaceRox1244
Copy link
Contributor Author

logic

  • be department that funds and supplies standard workplace procedure
  • no proof that artifact containers are developed by NT
  • mapped roundstart supplies implies nothing about intended source of supplies
  • entirely arbitrary to require players to unlock the ability to appropriately transport small artifacts
  • it’s a choice between two resource economies, money and materials
  • there's nothing technologically advanced about a smaller box for smaller things
  • this is not an anomalous storage space, like bags of holding, this is a regular shielded crate

Do not come into my PR with spite and insult and think that you will convince me of anything.

ArtisticRoomba
ArtisticRoomba approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute sprites, looks good to me.

Resources/Prototypes/Entities/Objects/Specific/Xenoarchaeology/artifact_equipment.yml
@@ -103,3 +102,92 @@
paper_label: !type:ContainerSlot
- type: StaticPrice
price: 250

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe clean up this white space here

@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Nov 17, 2024 •
edited
Loading

I agree should work like animal carrier and also this makes more sense as a science research than a cargo order.

It does not make sense as a science research.

With the suggested change of making it use an EntityStorage instead it becomes a more-portable and maneuverable artifact container than the OG one and can store both sizes of artifacts. The main use cases of artifact containers are containing rads (or rarely other likely to activate nodes), and catching living artifacts. This device would be better at both of those things.

@ayoitslilith
Copy link

I agree should work like animal carrier and also this makes more sense as a science research than a cargo order.

It does not make sense as a science research.

With the suggested change of making it use an EntityStorage instead it becomes a more-portable and maneuverable artifact container than the OG one and can store both sizes of artifacts. The main use cases of artifact containers are containing rads (or rarely other likely to activate nodes), and catching living artifacts. This device would be better at both of those things.

I think it would be better if it was for a specified use case than an upgrade to standard artifact containers. Why make it an upgrade that would obsolete standard artifact containers when instead it could be a specialized container for portable carrying? It would be like making backpacks an upgrade for crates.

@SpaceRox1244
Copy link
Contributor Author

SpaceRox1244 commented Nov 17, 2024 •
edited
Loading

With the suggested change of making it use an EntityStorage instead it becomes a more-portable and maneuverable artifact container than the OG one and can store both sizes of artifacts. The main use cases of artifact containers are containing rads (or rarely other likely to activate nodes), and catching living artifacts. This device would be better at both of those things.

Yall. No. Please. Its not gonna be an unlock, its not gonna be an upgrade, its not gonna be some multi-layered act of game design genius. It is a small shielded crate made to carry small alien artifacts.
I have no interest in designing features as if I were an in-universe scientist addressing station productivity in-character. If I were, Id just add a teleporter pad to beam the artifact to the ATS automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtisticRoomba ArtisticRoomba ArtisticRoomba approved these changes

Assignees
No one assigned
Labels
A: Cargo/Salvage Area: Cargo department or Salvage. A: Science Area: Science department, not including Silicons. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SpaceRox1244 @beck-thompson @thebadman4662 @IProduceWidgets @Kadeo64 @ayoitslilith @ArtisticRoomba @SaphireLattice