Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make storage implant drop items on gibbing #33493

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Make storage implant drop items on gibbing #33493

merged 7 commits into from
Jan 19, 2025

Conversation

Winkarst-cpu
Copy link
Contributor

@Winkarst-cpu Winkarst-cpu commented Nov 23, 2024 •
edited
Loading

About the PR

Title.

Why / Balance

No more items round removing using storage implant. Resolves #25524.

Technical details

Media

2024-11-23.16-50-08.mp4

Requirements

Breaking changes

Changelog

🆑

  • tweak: Now items from the storage implant drop on the floor upon gibbing of the owner.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Nov 23, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Nov 23, 2024
slarticodefast
slarticodefast approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, thanks for the fix.
However, dropping items on implanter removal was already working before this PR, could you adjust your PR title, description and changelog for that?

@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Nov 23, 2024
@slarticodefast slarticodefast self-assigned this Nov 23, 2024
@Winkarst-cpu Winkarst-cpu changed the title Make storage implant drop items on gib/removal Make storage implant drop items on gibbing Nov 23, 2024
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 23, 2024
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 23, 2024
@slarticodefast slarticodefast removed the S: Needs Review Status: Requires additional reviews before being fully accepted label Dec 16, 2024
@Winkarst-cpu @0x6273
Update Content.Server/Implants/ImplantedSystem.cs
cfd002e 
Co-authored-by: 0x6273 <0x40@keemail.me>
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 18, 2025
beck-thompson
beck-thompson approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested 🫡

@beck-thompson beck-thompson merged commit b09cd1c into space-wizards:master Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

@0x6273 0x6273 0x6273 approved these changes

@slarticodefast slarticodefast Awaiting requested review from slarticodefast

Assignees

@slarticodefast slarticodefast

Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage implant should drop items on crit / death
4 participants
@Winkarst-cpu @0x6273 @beck-thompson @slarticodefast