Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite Movement working with AI movement #33494

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Sprite Movement working with AI movement #33494

merged 2 commits into from
Dec 18, 2024

Conversation

TheShuEd
Copy link
Member

@TheShuEd TheShuEd commented Nov 23, 2024 •
edited
Loading

About the PR

Now AI movement can work with SpriteMovementSystem

Why / Balance

bug
fix #32187

Media

2024-11-23.17-13-50.mp4

Requirements

Changelog
to minor

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. labels Nov 23, 2024
@TheShuEd TheShuEd added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D1: High Difficulty: Extensive codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. size/L Denotes a PR that changes 1000-4999 lines. A: Art Area: Art with no implications for other areas. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. labels Nov 23, 2024
@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Nov 23, 2024 •
edited
Loading

Mostly commenting to follow so I can implement once merged.

The code is surprisingly straight forward though.
Thanks for working on this, I appreciate it.

metalgearsloth
metalgearsloth reviewed Nov 24, 2024
View reviewed changes
Content.Shared/Movement/Systems/SharedSpriteMovementSystem.cs
Comment on lines +19 to +21

ent.Comp.IsMoving = args.IsMoving;
Dirty(ent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this even needs to be networked? It's just getting derived from inputmover data.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SteeringSystem serveronly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i get it, yes, not needed for input mover

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metalgearsloth If I remove Dirty(), it won't work anymore. Neither when the creature is controlled by the AI, nor when the player

SlamBamActionman
SlamBamActionman approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this ingame with various other creatures. The change to spider parentage is possibly a bit out of scope for the PR, but still works.

@SlamBamActionman SlamBamActionman merged commit 18fe8b9 into space-wizards:master Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth metalgearsloth left review comments

@SlamBamActionman SlamBamActionman SlamBamActionman approved these changes

Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. D1: High Difficulty: Extensive codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: Bugfix Type: Bugs and/or bugfixes T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When mobs move themselves, there is no movement animation
4 participants
@TheShuEd @IProduceWidgets @metalgearsloth @SlamBamActionman