-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cotton baguette, crostini, chevre-chaud, bagel, and croissant foods for moffs #33508
base: master
Are you sure you want to change the base?
New cotton baguette, crostini, chevre-chaud, bagel, and croissant foods for moffs #33508
Conversation
RSI Diff Bot; head commit 4bd2fc4 merging into f476526 Resources/Textures/Objects/Consumable/Food/Baked/bagel.rsi
Resources/Textures/Objects/Consumable/Food/Baked/bread.rsi
Resources/Textures/Objects/Consumable/Food/Baked/misc.rsi
Resources/Textures/Objects/Consumable/Food/ingredients.rsi
|
yeah this is fire |
lethimcook |
I'm gonna be honest, it looks moldy. Good addition regardless, always happy to see more moth food variety. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires some changes to make the entities contain fiber. The sprites will also require art maintainer approval; there is a concern it may look moldy, but at the same time we already have moldy bread and that is a very noticeable green, so this might be fine.
…d in the food (the food that's intended for moffs)
…nd croissant-cotton.png
I've addressed your review (lol good job me) as well as pushed some alternative sprites in commit 3eecac7 for the art directors to see if they don't like the 3 original sprites. Let me know if the sprites are not up to par. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the code side, looks good! Sprites will need art maintainer approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raw croissant and chevre-chaud sprites need to look more unique since they're really close to their counterpart sprites right now, and the bagel/cooked croissant sprites shouldn't look moldly. You can probably fix it by giving a layer of cotton in the middle (like a bagel sandwich) or almost like icing on the top... and for the croissant you could probably add cotton underneath the slits(?), like where the flaps/layers of the croissant are. The other sprites look fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make the raw croissant sprite and the cooked cotton croissant sprites line have the cotton part line up. You can go either direction here, with it being spotted or just on the inner parts... or both. Doesn't matter too much.
Sorry for not mentioning this earlier, but the rest of the sprites look fine to me.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # Resources/Prototypes/Recipes/Cooking/meal_recipes.yml
About the PR
Adds new foods, all made from new cotton dough slices and cotton dough rolls.
The cotton baguette, cotton crostini, cotton chevre-chaud, cotton bagel, and cotton croissant.
You can make them by following the recipes for regular dough, but use cotton dough instead.
Why / Balance
Was marked as a TODO. Poor moffs need more foods and I think this will give chefs a lot of opportunity to have fun and make some fine dishes for the fellow moffs.
Technical details
Just YAML changes.
Media
Requirements
Changelog
🆑 ArtisticRoomba, JuneSzalkowska