Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix airlocks inconsistently auto-closing after unbolting #33524

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

slarticodefast
Copy link
Member

@slarticodefast slarticodefast commented Nov 24, 2024

About the PR

The autoclose timer is now correctly being reset after unbolting an opened door.
Two scenarios in which this bug previously occured on master:

A:

  • spawn an airlock and emag
  • emag the airlock
  • open the wirepanel and use a multitool to pulse the bolts wire to unbolt the door
  • the door won't autoclose until closed manually

B:

  • spawn an airlock and command door remote
  • walk into the airlock so it opens, then activate the bolts using the remote so it stays open
  • if you wait less than 5 seconds to unbolt again, then the door will wait a while until closing
  • if you wait more than 5 seconds to unbolt, the door will close immediately

Why / Balance

bugfix

Technical details

Added DoorBoltsChangedEvent and raise it in SetBoltsDown.
Subscribe to it in SharedAirlockSystem to update the auto-close timer.
Added a Dirty() into SetNextStateChange so the timer is correctly networked.
Added the readonly ViewVariables attribute to the NextStateChange variable in DoorComponent to make debugging it easier.

Requirements

Breaking changes

none

Changelog
🆑

  • fix: Fixed doors not auto-closing correctly after being unbolted in an open state.

@slarticodefast slarticodefast changed the title fix airlocks not inconsistently auto-closing after unbolting fix airlocks inconsistently auto-closing after unbolting Nov 24, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 24, 2024
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 24, 2024
@metalgearsloth metalgearsloth merged commit 3c6c5ab into space-wizards:master Nov 25, 2024
14 checks passed
@slarticodefast slarticodefast deleted the doortimer branch November 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants