fix airlocks inconsistently auto-closing after unbolting #33524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The autoclose timer is now correctly being reset after unbolting an opened door.
Two scenarios in which this bug previously occured on master:
A:
B:
Why / Balance
bugfix
Technical details
Added
DoorBoltsChangedEvent
and raise it inSetBoltsDown
.Subscribe to it in
SharedAirlockSystem
to update the auto-close timer.Added a
Dirty()
intoSetNextStateChange
so the timer is correctly networked.Added the readonly
ViewVariables
attribute to theNextStateChange
variable inDoorComponent
to make debugging it easier.Requirements
Breaking changes
none
Changelog
🆑