Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolshed refactor #33598

Merged
merged 5 commits into from
Dec 21, 2024
Merged

Toolshed refactor #33598

merged 5 commits into from
Dec 21, 2024

Conversation

ElectroJr
Copy link
Member

@ElectroJr ElectroJr commented Nov 27, 2024 •
edited
Loading

About the PR

This PR contains content changes for an engine PR. See that PR for a detailed description.
requires space-wizards/RobustToolbox/pull/5455.

fixes #26672

🆑

  • tweak: Toolshed console commands have been reworked. Some old commands may no longer work.

@ElectroJr ElectroJr added the S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. label Nov 27, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 27, 2024
@ScarKy0 ScarKy0 added P1: High Priority: Higher priority than other items, but isn't an emergency. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: Toolshed Area: Toolshed, the command interpreter, related changed or fixes T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 27, 2024
@ElectroJr
Copy link
Member Author

toolshed won't be the shit it was before?

Assuming you mean the help command #26672, it doesn't currently fix that, but I see several issues there that I could also fix in the engine PR. Otherwise it doesn't generally change all that much, the syntax is generally the same and it still doesn't yet add client-side commands or optional arguments.

@space-wizards space-wizards deleted a comment from lzk228 Nov 29, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Dec 21, 2024
@ElectroJr ElectroJr merged commit 06e2bba into space-wizards:master Dec 21, 2024
13 checks passed
@ElectroJr ElectroJr mentioned this pull request Dec 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

Assignees
No one assigned
Labels
A: Toolshed Area: Toolshed, the command interpreter, related changed or fixes D2: Medium Difficulty: A good amount of codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TOOLSHED REQUEST] toolshed commands help is shit
2 participants
@ElectroJr @ScarKy0