Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major UI Improvement #33632

Closed

Conversation

VlaDOS1408
Copy link
Contributor

@VlaDOS1408 VlaDOS1408 commented Nov 28, 2024

About the PR

I've fixed Resizable for Fun, Cargo, Communication Console, improved the appearance of fax, cargo console, and particle accelerator. Fixed bugs and all that stuff. Now in the Russian localization, the particle accelerator menu does not become vertical. In short, I improved and upgraded a lot of things.

Why / Balance

Initially, I was annoyed that I couldn't properly resize the communication console and it wasn't working properly, but then I went to fix everything I saw. Many menus in the Russian localization are broken, as the words in some places are forced to be much longer than in English. The cargo console is generally difficult to use! There was nothing to see, and the particle accelerator console looked like after the apocalypse

Technical details

I cleaned up and cleaned all the files that I touched.

Media

Below
Ps: I will also attach a few screenshots with RU localization before

Changelog
🆑

  • tweak: Cargo console reworked
  • tweak: Fax menu reworked
  • fix: fix PA console menu
  • fix: fix Communication Console resizable
  • fix: fix PowerCharge menu (Gravity generator)
  • fix: fix shuttle map status-invalid locale

UIUpdate_CargoConsole

UIUpdate_CargoConsole-Huge
UIUpdate_CargoConsole-Low
UIUpdate_CommCons
UIUpdate_CommCons-Big
UIUpdate_Fax
2024-11-29_00-07-48
UIUpdate_FixFTL
UIUpdate_PA

@github-actions github-actions bot added Changes: UI Changes: Might require knowledge of UI design or code. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XL Denotes a PR that changes 5000+ lines. labels Nov 28, 2024
@PJB3005
Copy link
Member

PJB3005 commented Nov 28, 2024

I'm going to need to see an actual PR description about the changes here.

@VlaDOS1408

This comment was marked as abuse.

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 28, 2024
@lzk228
Copy link
Contributor

lzk228 commented Nov 28, 2024

you'll probably have to split up those things in smaller prs to getting reviewed faster
also please upload actual screenshots from wizden's build

@VlaDOS1408

This comment was marked as abuse.

@MilenVolf
Copy link
Contributor

fk, lazik, where do you think I downloaded these screenshots from? Everything below the mark is for a general understanding of the picture. Everything above is relevant. Or are you confused by that 1 single screenshot from the corvax build? Well, I just forgot to take a stretched screenshot of the fax on wisden.

I agree with lzk. Please split up this PR so it will be easier to review the changes you've made. It got too many screenshots. I assume that the video format would be much preferable

@slarticodefast
Copy link
Member

Yeah, this needs to be split up into one PR for each device. Not only for making the review easier, but also to reduce potential merge conflicts for forks who maybe have made changes to one of them.

@VlaDOS1408

This comment was marked as abuse.

@MilenVolf
Copy link
Contributor

MilenVolf commented Nov 29, 2024

Yeah, this needs to be split up into one PR for each device. Not only for making the review easier, but also to reduce potential merge conflicts for forks who maybe have made changes to one of them.

What categories do you want me to divide my work into?

For example
CargoProductRow.xaml with CargoProductRow.xaml.cs in one PR, CargoConsoleMenu.xaml with CargoConsoleMenu.xaml.cs, etc.
xamls that were modified alone could also be in a separate PR, like FaxWindow.xaml

@VlaDOS1408

This comment was marked as abuse.

@slarticodefast
Copy link
Member

That would be perfect, thanks!

@VlaDOS1408

This comment was marked as abuse.

@slarticodefast
Copy link
Member

grafik
Clcik on "Convert to draft" on the right side

@VlaDOS1408 VlaDOS1408 closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/XL Denotes a PR that changes 5000+ lines. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants