Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nacho recipes #33637

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

CheddaCheez
Copy link
Contributor

About the PR

This adds recipes for three types of nachos. They're in the game via spawner, just not able to be cooked until now.

Why / Balance

These foods are practically implemented outside of missing a cooking recipe.

Technical details

In meal_recipes.yml: Add recipes for Nachos, Cheesy Nachos, and Cuban Nachos.
In meals.yml: Add a solutions container to regular nachos so it lines up with the others, and add a small plate as trash to each one.

Media

Nachos
https://github.com/user-attachments/assets/fb98f43c-9350-43c8-8e71-b556594fb540
Cheesy Nachos
https://github.com/user-attachments/assets/4d0faf25-752c-4a3f-a43d-be7e8faa7821
Cuban Nachos
https://github.com/user-attachments/assets/2a7a39a7-7bb5-44a8-b52a-8120c33c420a

Requirements

Changelog
🆑

  • add: Added recipes for Nachos, Cheesy Nachos, and Cuban Nachos.

In meal_recipes.yml: Add recipes for Nachos, Cheesy Nachos, and Cuban Nachos.

In meals.yml: Add a solutions container to regular nachos so it lines up with the others, and add a small plate as trash to each one.
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 29, 2024
@UbaserB
Copy link
Member

UbaserB commented Nov 29, 2024

yum

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Service Area: Service department, including cooking, botany, etc labels Nov 29, 2024
In meals.yml: Lowered maxVol on nachos to leave 5 units of space. Nachos nutriment and vitamin lowered for costing so little. A cheese wedge is 3.75 nutriment, so cheesy having 4 more total nutritional value lines up nicely to me.

Cuban nachos had too little volume to fit its reagents in the first place, so increased maxVol by 10. Chili peppers are 4 nutri / 4 vitamin and ketchup has a touch of tomato, so bumped to 8 and 5. Capsaicin lowered partly to make it an even 20u. Ketchup dilutes I guess. Also they don't have cheese so I changed the flavor profile to tomato instead.

In meal_recipes.yml: Cuban Nachos recipe tweaked to require one less pepper. Given above numbers, this fits the nutritional value imo.
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contribution!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 1, 2024
@slarticodefast slarticodefast self-assigned this Dec 1, 2024
@chromiumboy
Copy link
Contributor

Mmm, nachos. Sounds good

@chromiumboy chromiumboy merged commit e50c98c into space-wizards:master Dec 3, 2024
12 checks passed
@CheddaCheez CheddaCheez deleted the NachoCheez branch December 5, 2024 18:00
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
* Nacho recipes, nutrition, and trash

In meal_recipes.yml: Add recipes for Nachos, Cheesy Nachos, and Cuban Nachos.

In meals.yml: Add a solutions container to regular nachos so it lines up with the others, and add a small plate as trash to each one.

* Volumes, nutritional tweaks, and flavor

In meals.yml: Lowered maxVol on nachos to leave 5 units of space. Nachos nutriment and vitamin lowered for costing so little. A cheese wedge is 3.75 nutriment, so cheesy having 4 more total nutritional value lines up nicely to me.

Cuban nachos had too little volume to fit its reagents in the first place, so increased maxVol by 10. Chili peppers are 4 nutri / 4 vitamin and ketchup has a touch of tomato, so bumped to 8 and 5. Capsaicin lowered partly to make it an even 20u. Ketchup dilutes I guess. Also they don't have cheese so I changed the flavor profile to tomato instead.

In meal_recipes.yml: Cuban Nachos recipe tweaked to require one less pepper. Given above numbers, this fits the nutritional value imo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants