Fix the inability to drag clumsy entities into the biomass reclaimer #33844
+18
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Some conditions in ClumsySystem were modified, so now in climbing condition clumsiness will work only if a clumsy mob will climb by itself, but if somebody will drag you onto the table, clumsiness will not work.
It was made due to the bug and comment that says that it was intended behaviour. Previously you could kill the clumsy person by non-stop dragging them onto the table (condition was always
true
because ofargs.PuttingOnTable == ent.Owner
and the usage of&&
.Why / Balance
Fixes #33819
Technical details
Moves
BiomassReclaimerComponent
to Shared to use it in new condition inClumsySystem
This PR adds new condition in
ClumsySystem
, that checks forBiomassReclaimerComponent
on a target.Also modifies conditions
Before:
After
Media
Climbing
Content.Client_iVFOdhw0Ry.mp4
Dragging into reclaimer
Content.Client_MWXTdM4YKd.mp4
Requirements
Changelog
🆑