Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Mono thing (2) #33853

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bedroomvampire
Copy link

@bedroomvampire bedroomvampire commented Dec 14, 2024

Working on making the mono-spaced font not hard-coded.
(attempt #3, changed some line due to an error)

About the PR

  • Added NotoSansMono-Regular.ttf on /Resources/Fonts/NotoSans/.
  • Changed part (line 180) of StyleNano.cs to use the mono font in "/Resources/Fonts/NotoSans/" instead.
  • Changed monospaced font path in /Resources/Prototypes/fonts.yml to "/Resources/Fonts/NotoSans/".

Why / Balance

  • To make it less hard-coded. (for easier font changing)

Technical details

  • Content.Client/Stylesheets/StyleNano.cs
    Original:
    var notoSansMono = resCache.GetFont("/EngineFonts/NotoSans/NotoSansMono-Regular.ttf", size: 12);
    New:
    var notoSansMono = resCache.GetFont("/Fonts/NotoSans/NotoSansMono-Regular.ttf", size: 12);
  • Resources/Prototypes/fonts.yml
    Original:
    path: /EngineFonts/NotoSans/NotoSansMono-Regular.ttf
    New:
    path: /Fonts/NotoSans/NotoSansMono-Regular.ttf

Media

Requirements

Breaking changes

Changelog

Working on making the mono-spaced font not hard-coded.
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 14, 2024
@bedroomvampire bedroomvampire changed the title Noto Sans Mono thing (1) Noto Sans Mono thing (2) Dec 14, 2024
@bedroomvampire
Copy link
Author

A screenshot showing a different monospaced font. (No editing RobustToolbox files involved)
Screenshot_2024_12_14_13:03:26

@tutoumi
Copy link

tutoumi commented Dec 16, 2024

....Uuuuuuh....sans mentionned ? undertale reference ?....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants