Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix followers getting sent to nullspace when target is polymorphed #33878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix followers getting sent to nullspace when target is polymorphed #33878

wants to merge 2 commits into from
+29 −0

Conversation

Tayrtahn
Copy link
Member

About the PR

Followers (ghosts, anomaly cores) orbiting targets will now continue orbiting the polymorph's result rather than getting tucked away in nullspace.

Why / Balance

Fixes #28778

Technical details

PolymorphSystem now raises a PolymorphedEvent on the targeted entity immediately after making the swap. FollowerSystem subscribes to this event and reacts by setting the new entity as follow target.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: Ghosts are no longer sent to the void if the player they are following is polymorphed.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 15, 2024
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 15, 2024
@beck-thompson beck-thompson mentioned this pull request Dec 15, 2024
Closed
@slarticodefast
Copy link
Member

slarticodefast commented Dec 16, 2024 •
edited
Loading

I found two bugs while testing:

  • The camera rotation is weird when following the polymorphed entity.
    grafik

  • When unpolymorphing the following ghost gets parented to the target, but does not have the rotating animation.
    grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. size/S Denotes a PR that changes 10-29 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghost follow is broken by polymorph
3 participants
@Tayrtahn @slarticodefast @beck-thompson