Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Christmas anomaly #33889

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Christmas anomaly #33889

merged 7 commits into from
Dec 16, 2024

Conversation

TheShuEd
Copy link
Member

@TheShuEd TheShuEd commented Dec 16, 2024 •
edited
Loading

About the PR

Added Christmas anomaly
spawn presents, include Insane on supercrit
time to gambling singularity

Why / Balance

remove in 2025

Media

2024-12-16.18-24-48.mp4

Requirements

Changelog
🆑

  • add: Christmas anomaly added
  • add: Christmas anomaly infection added

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 100-1000 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. and removed size/L Denotes a PR that changes 100-1000 lines. labels Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

RSI Diff Bot; head commit f02b1dd merging into 046dde7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Specific/Anomalies/Cores/santa_core.rsi

State Old New Status
core Added
pulse Added

Resources/Textures/Structures/Specific/Anomalies/inner_anom_layer.rsi

State Old New Status
santa Added

Resources/Textures/Structures/Specific/Anomalies/santa_anom.rsi

State Old New Status
anom Added
pulse Added

Edit: diff updated after f02b1dd

@TheShuEd TheShuEd added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Science Area: Science department, not including Silicons. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 16, 2024
@K-Dynamic
Copy link
Contributor

Time to dress as santa and get infected by present anomaly

FairlySadPanda
FairlySadPanda reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@FairlySadPanda FairlySadPanda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but rather than adding code to rip out, this feels like it should be behind a cvar so it can be used yearly. (Same as, say, a Santa retheme for Wizard during December)

@Errant-4
Copy link
Member

This is great but rather than adding code to rip out, this feels like it should be behind a cvar so it can be used yearly. (Same as, say, a Santa retheme for Wizard during December)

We wouldn't need to rip out the code, just comment this one out in Spawners/Random/anomaly.yml

@FairlySadPanda
Copy link
Contributor

This is great but rather than adding code to rip out, this feels like it should be behind a cvar so it can be used yearly. (Same as, say, a Santa retheme for Wizard during December)

We wouldn't need to rip out the code, just comment this one out in Spawners/Random/anomaly.yml

Yeah, true, although the advantage of a toggle-driven system is that it allows for easy admemeing...

But that's a bikeshed on what looks like a cracking PR :godo:

@TheShuEd @ScarKy0
Update Resources/Locale/en-US/anomaly/inner_anomaly.ftl
8a0c1f3 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-1000 lines. label Dec 16, 2024
TheShuEd and others added 2 commits December 16, 2024 19:29
@TheShuEd @Errant-4
Update Resources/Textures/Structures/Specific/Anomalies/Cores/santa_c…
c55919e 
…ore.rsi/meta.json

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
@TheShuEd @Errant-4
Update Resources/Textures/Structures/Specific/Anomalies/santa_anom.rs…
f02b1dd 
…i/meta.json

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
@beck-thompson
Copy link
Contributor

I love this so much ❤️

@TheShuEd
Copy link
Member Author

SELFMERGE SCREAMER

@TheShuEd TheShuEd merged commit 36c6767 into space-wizards:master Dec 16, 2024
14 checks passed
@cfif126
Copy link

cfif126 commented Dec 16, 2024

bro activate your windows massgrave is real

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FairlySadPanda FairlySadPanda FairlySadPanda left review comments

@ScarKy0 ScarKy0 ScarKy0 requested changes

@Errant-4 Errant-4 Errant-4 approved these changes

Assignees
No one assigned
Labels
A: Science Area: Science department, not including Silicons. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 100-1000 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TheShuEd @K-Dynamic @Errant-4 @FairlySadPanda @beck-thompson @cfif126 @ScarKy0