Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement field-deltas for melee #33977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement field-deltas for melee #33977

wants to merge 1 commit into from

Conversation

metalgearsloth
Copy link
Contributor

Title.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Dec 21, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Combat Area: Combat features and changes, balancing, feel A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 22, 2024
SlamBamActionman
SlamBamActionman requested changes Mar 8, 2025
View reviewed changes
Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/orgs/community/discussions/4452 Thanks Github.

The following lines change component properties without dirtying them.
SharedMeleeWeaponSystem, line 444, line 838.
ZombieSystem.Transform, lines 128-133, line 178. (I assume it isn't necessary here since so many fields are being changed it's just easier to dirty the entire comp)

Can you confirm if these instances are being handled correctly? Otherwise, code looks good.

Also use the PR template wawa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlamBamActionman SlamBamActionman SlamBamActionman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metalgearsloth @SlamBamActionman @beck-thompson