Renamed "Irish Car Bomb" drink to "Irish Slammer"

[Alpaccalypse]

About the PR

An issue was raised that the name "Irish Car Bomb" was insensitive and jarring with the spirit of the game. There were no immediate complaints against the idea of changing the name, so this PR addresses that issue by renaming the drink to "Irish Slammer" a recognised alternative name for this drink.

Fixes #34102

Why / Balance

There is no tangible impact on the game by changing this name, and it avoids needless controversy, at odds with the purported spirit and principles of SS14.

Technical details

Changes all references of "Car Bomb" to "Slammer"

Media

Requirements

• [ X] I have read and am following the Pull Request and Changelog Guidelines.
• [ X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Hopefully none, though there was a lot of cross referencing that needed to be found and corrected. All character and formatting variations of the term "Car Bomb", in files, should now read as matching variations of "Slammer"

Changed strings:

• Objects/Consumable/Drinks/irishslammer.rsi (resources folder name)
• reagent-name-irish-slammer = irish slammer (alcohol.ftl)
• reagent-desc-irish-slammer = An unconventional mixture of irish cream and stout. (alcohol.ftl)
• flavor-complex-irish-slammer (flavor-profiles.ftl)
• id: IrishSlammer and all other variations of "Car Bomb" to "Slammer" (alcohol.yml)
• id: DrinkIrishSlammer and all other variations of "Car Bomb" to "Slammer" (Consumable/Drinks/drinks.yml)
• IrishSlammer multiple lines (Recipes/Reactions/drinks.yml)
• DrinkIrishSlammer (drinks_glass.yml)
• id: irishslammer (flavors.yml)
• description: flavor-complex-irish-slammer (flavors.yml)

Changelog
🆑

• tweak: "Irish Car Bomb" renamed to "Irish Slammer".

[github-actions]

RSI Diff Bot; head commit e59745f merging into 01980cb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after e59745f

[lzk228]

add all changed entities to migration.yml

[lzk228]

scarky already said, but i think it still can be useful
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

[Alpaccalypse]

add all changed entities to migration.yml

I think I did this right? Wasn't sure if all "ID" field changes should be added or not.

[slarticodefast]

Looks good to me.
Could you add a list of all changed file, prototype and translation string names to the breaking changes section of your PR? This is relevant for forks using them.

[Alpaccalypse]

Looks good to me. Could you add a list of all changed file, prototype and translation string names to the breaking changes section of your PR? This is relevant for forks using them.

No problem. Done.

[FairlySadPanda]

Reading through the YAML, this drink is actually wrong anyway.

A Car Bomb/Irish Slammer/Dublin Drop/etc is made with three ingredients - you layer a shot glass with irish cream and Irish whiskey like Jameson's, then drop it into 3/4s of a pint of something like Guinness.

The game appears to model this by "whiskey + cream = irish cream", "irish cream + ale" = the cocktail.

To be a bit of a snob, I'm not sure if there's any advantage at all to having this drink in-game if it's not actually modelling the cocktail! This is a party drink all about being forced to chug the entire drink in a few seconds to avoid the base stout curdling the cream.

What you'd get with ale + irish cream is... probably quite disgusting.

[Errant-4]

From a different angle, such a drink having only so much to do with it's pre-ftl namesake makes no less sense than it remaining unchanged for hundreds of years of serious cultural changes

[FairlySadPanda]

Reading into this actually, maybe calling it an Irish Boilermaker would be a good compromise, as a boilermaker is whiskey + beer.

[superjj18]

I feel like removing the joke turns the item into dull bloat that can just be removed. Now it's just vague legally distinct alcohol beverage #33.

Feel like the crude irreverence is perfectly inline with SS13/14's sense of humor.

Hell car-bomb-esque strategies are literally prime SS14 gameplay. As for the historic significance, the Irish history parallels very well with the Revolutionaries gamemode.

I don't think there is enough reason to remove it, and I believe this change only dulls the spirit of the game.

[IamVelcroboy]

Honestly, we should just add the Twin Towers so everyone is equally offended and it's win/win all around because we've all learned to take a joke together.

[FairlySadPanda]

If it needs to have an explosive name then calling it something nukies themed would work best. E.g. a Nuclear Operative, or a Gorlex Marauder. Both are good cocktail names

[Sarahon]

I'm Irish, we call it that in Ireland lol. It's not insensitive.

[CrazyAmphibian]

I'm Irish, we call it that in Ireland lol. It's not insensitive.

Yes, but it's insensitive to Brits because the IRA mogged on them.

[Iamgoofball]

Honestly, we should just add the Twin Towers so everyone is equally offended and it's win/win all around because we've all learned to take a joke together.

The Twin Stations.

[BasedUser]

Honestly, we should just add the Twin Towers so everyone is equally offended and it's win/win all around because we've all learned to take a joke together.

The Twin Stations.

motherfucker i'm going to make the "split station" an actual drink at that rate

[Alpaccalypse]

Why not just re-make it as something relevant to ss14 lore and remove any reference to the real world at all? Something like Pan Galactic Gargle Blaster makes sense to me, but this is just a bit jarring to the tone/theme of the game, regardless or real-world sensibilities.

As for removing/renaming it or not, having read the related issue, I just didn't see any reason not to re-name it. I can't see why it would be more important to someone to keep one name for it that references some pretty horrific experiences some people have lived through not so long ago, and another name, just as valid, that doesn't.

I'd be happy to drop the PR just to avoid any drama over this, but I'd be even happier to just let this go through for the same reason.

P.S. And I love the idea of making a Gorlex Marauder cocktail for the game.

[Errant-4]

As I noted on the issue, I think that changing this is reasonable, I think the replacement is fine. I would rather go with this proposal than get stuck bikeshedding for what is the optimal replacement that everyone agrees on.
If someone has a proposal they think is more thematic, please open a PR for changing the locale. I don't really see the need to change the identifiers and filenames from slammer. The same option is available to any forks that wish to retain the car-bomb. Or they can just outright revert this change entirely on their end (though accepting the filename and locale identifier changes and only reverting the localisation will probably be smoother in the future if any of this ever gets changed again)

[Alpaccalypse]

If it needs to have an explosive name then calling it something nukies themed would work best. E.g. a Nuclear Operative, or a Gorlex Marauder. Both are good cocktail names

As you pointed out it was technically wrong anyway, and I was already thinking of lore friendly renaming, as suggested in other comments, I went ahead and made a PR draft which renames this and related drinks to in-universe references. Irish Car Bomb becomes "Grenade Penguin" and "Irish Bool" becomes "Exploding Syndicat" among other changes. I wont actually link it, as I'd like to start that PR draft independent from some of the subjective and real-world concerns raised here (though this comment is not a criticism of those concerns).

[FairlySadPanda]

I think Grenade Penguin is an S++ tier name for this drink :)

Generally "irish cream" etc is fine, it's just this particular drink that's got an out-of-date name.

[Sarahon]

I think Grenade Penguin is an S++ tier name for this drink :)

Generally "irish cream" etc is fine, it's just this particular drink that's got an out-of-date name.

Um, I dunno how it does truthfully. I always saw the drinks as representing the fact that a lot of it came from what was earth + the likely reference to super past heritage situations. If "Irish car bomb" is out of date, then so would Irish cream be, for the exact same reason really.

[Sarahon]

If it needs to have an explosive name then calling it something nukies themed would work best. E.g. a Nuclear Operative, or a Gorlex Marauder. Both are good cocktail names

As you pointed out it was technically wrong anyway, and I was already thinking of lore friendly renaming, as suggested in other comments, I went ahead and made a PR draft which renames this and related drinks to in-universe references. Irish Car Bomb becomes "Grenade Penguin" and "Irish Bool" becomes "Exploding Syndicat" among other changes. I wont actually link it, as I'd like to start that PR draft independent from some of the subjective and real-world concerns raised here (though this comment is not a criticism of those concerns).

You might as well hold off and rename every earth drink at that point then, cause it just looks like a PR targeted at only the Irish stuff right now which just feels ass.