Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERT loadout improvements #34506

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 18, 2025

About the PR

Modernized the starting equipment of ERT operatives with the general goal of giving them all of the gear required for their job, rather than just some of it. Added more heavily armed ERT variants for fighting big threats, now referred to as "ERT Marines".

Why / Balance

ERT Operatives have lots of storage, but not much to fill it. They generally have to scavenge station equipment after arriving, which makes little sense and is annoying. I've often seen admins counter this by spawning in extra equipment alongside the operatives, but it would make a lot more sense to just give them a full kit. Unarmed ERT members were essentially walking lootbags for antagonists, so they deserve to have a pistol. They are elite military personnel after all.
I figured it would be nice to consolidate all of the heavily armed ERT operatives under the name "ERT Marines" to make them easier to find for admins.

Technical details

Changed the content of emergencyresponseteam.yml and humanoid.yml.

Media

ERT Leader
ERT Chaplain
ERT Engineer
ERT Janitor
ERT Medic
ERT Security
(EVA variants of all above are not pictured for your sanity)

ERT Marines Leader
ERT Marines Rifleman
ERT Marines Breacher
ERT Marines Grenadier
ERT Marines Medic

Requirements

Breaking changes

Changed RandomHumanoidSpawnerERTLeaderEVALecter to RandomHumanoidSpawnerERTMarinesLeader, and ERTLeaderGearEVALecter to ERTMarinesGearLeader.
Changed RandomHumanoidSpawnerERTSecurityEVALecter to RandomHumanoidSpawnerERTMarinesRifleman, and ERTSecurityGearEVALecter to ERTMarinesGearRifleman.

Changelog
🆑

  • add: All ERT members now have a mk58 pistol and combat knife.
  • add: New heavily armed ERT variants: breacher, grenadier, and medic.
  • tweak: ERT backpacks are slightly less absurdly large and slow you down by 5%.
  • tweak: Consolidated the "Armored EVA" and "Envrio EVA" tags into "EVA".
  • tweak: All longarm-equipped ERT members are now classified as ERT marines for easier searching.
    -->

Nox38 and others added 7 commits January 12, 2025 19:21
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 18, 2025
@Nox38 Nox38 marked this pull request as ready for review January 18, 2025 19:57
@Nox38 Nox38 requested a review from DrSmugleaf as a code owner January 18, 2025 19:57
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 18, 2025
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor YML nitpicks among other things

Copy link
Contributor

@Blackern5000 Blackern5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a non-syndicate compact defib with the interdyne defib and interdyne bundle, I want to add it as a sci tech some day but it still exists in the game and I think ERT would make good use of it.

Copy link
Contributor

@IProduceWidgets IProduceWidgets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My broader critique is that this probably adds too much stuff to the loadouts. Ironically, adding stuff to the loadouts makes them far less flexible. On the fly its very easy as an admin to add items you want them to have, extra gear etc. Its very annoying and difficult to remove it.

While there is something to be said for making ERT easy to send, we don't want ERT to be shoehorned into specific uses. They should be first and foremost RP roles, even the security one, despite some of them being used for counter-nukies frequently.

For these reasons I think it makes more sense to give them gear in other ways where they have a chance to interact with eachother and make gear choices. The natural way to do that is mapping, but we have admittedly been a bit back and forth on whether we want to maintain ERT specific maps/grids and scenarios at all.

I think some of these changes, and many of the item tweaks/changes, are good, but I think with the many additions they're too much in totality.

A lot of the balance of ERT is intended to be less effective but mechanically comparable to nukies. See their suit armors, and weapon varieties, etc. Also please consider, ERT, even for nukies, only really arrive late into the disaster when many of the resources to cause said disaster have already been spent.

Comment on lines +121 to +130
id: RandomHumanoidSpawnerERTMarinesLeader
parent: RandomHumanoidSpawnerERTLeaderEVA
suffix: ERTRole, Lecter, EVA
name: ERT marines leader
suffix: ERTRole, Marines, Rifle
components:
- type: RandomHumanoidSpawner
settings: ERTLeaderEVALecter
settings: ERTMarinesLeader

- type: randomHumanoidSettings
id: ERTLeaderEVALecter
id: ERTMarinesLeader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a name change needs workshopping as this is confusing with the Colonial Marines which its not at all relevant to.

Also, changing any of these IDs is probably not worth it since it just causes conflicts for almost no benefit. At the very least it needs everything added to migrations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the colonial marines is a different branch, I don't see how its relevant? I'm open to name suggestions if you have any ideas though.

head: ClothingHeadHelmetERTLeader
eyes: ClothingEyesGlassesSecurity
gloves: ClothingHandsGlovesCombat
outerClothing: ClothingOuterArmorBasicSlim
id: ERTLeaderPDA
ears: ClothingHeadsetAltCentCom
belt: ClothingBeltSecurityFilled
belt: ClothingBeltSecurityWebbing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the webbing, it doesn't have the extra sprite work of the belt.
changing them to use dynamic filling by loadout is better however, that's a good idea, id just stick with the belts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the webbing looks more military.. Ideally, id give NT operatives their own version of the web vest, maybe ill ask if anyone is interested in making a sprite for that.

Comment on lines +572 to +588
belt:
- AntiPoisonMedipen
- AntiPoisonMedipen
- BruteAutoInjector
- BruteAutoInjector
- BruteAutoInjector
- AirlossAutoInjector
- AirlossAutoInjector
- AirlossAutoInjector
- RadAutoInjector
- RadAutoInjector
- PunctAutoInjector
- PunctAutoInjector
- PunctAutoInjector
- PyraAutoInjector
- PyraAutoInjector
- PyraAutoInjector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These just defeat the purpose of the advanced hypospray they have at this quantity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are not many prefilled bottles in-game at the moment, so unless we want to add a ton of bloat by making pre filled bottles for all their chems, this is the only way to do it.

@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Jan 18, 2025

Something I had been considering, and you might enjoy, is adding a variant of the chaplain with a claymore and shield, and avoiding giving them guns. Their eva suit is equivalent to the nukie jug suit armor wise, and its a sort of funny way to add a melee option for counter-nukie stuff without making them immediately and obviously OP.

@IProduceWidgets
Copy link
Contributor

An alternative I have used before is placing a lot of this gear onto a supply bot, and then having the supply bot serve as a team resource. That also makes the gear much more modularly flexible.

@Aeshus Aeshus added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Combat Area: Combat features and changes, balancing, feel A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 19, 2025
@Nox38
Copy link
Contributor Author

Nox38 commented Jan 21, 2025

Their eva suit is equivalent to the nukie jug suit armor wise,

I need to redo their suit stats, ill start on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants