feat!: put merlin behind feature
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
force-pushed
the
feat/merlin-behind-feature
branch
2 times, most recently
from
0c6a460 to
0834695
Compare
6 tasks
JayWhite2357
changed the title
merlin behind featuremerlin behind feature
…`merlin::Transcript`
… of `merlin::Transcript`
JayWhite2357
force-pushed
the
feat/merlin-behind-feature
branch
from
0834695 to
d59ec73
Compare
stuarttimwhite
approved these changes
Sep 26, 2024
tlovell-sxt
approved these changes
Sep 26, 2024
|
🎉 This PR is included in version 0.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #161 for rationale.
What changes are included in this PR?
NOTE: the individual commits may be good to review individually
DoryMessagesacceptsimpl Transcriptinstead ofmerlin::Transcript. This is a breaking change, making the proofs non-backward compatible. The API deos not change.Changed
CommitmentEvaluationProofto acceptimpl Transcriptrather thanmerlin::Transcript.Replaced
merlin::TranscriptwithKeccak256TranscriptwithinQueryProof. Although the proof could be made generic, there is no real use-case formerlin. In the future, we can easily support other transcripts, but I think it is best to keep it concrete for now.Dropped dead code and renamed the old
merlinmodule.Put
merlinbehind theblitzarfeature flag since it is still required for theblitzar::InnerProductProof.The tests are NOT refactored to remove
merlin. This can be done in a separate PR.Are these changes tested?
Yes. Existing tests cover the changes.