refactor!: modify ProofExpr::result_evaluate to return ColumnarValue and remove table_length as arg
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR replaced #334 |
iajoiner
force-pushed
the
feat/remove-len
branch
from
a846cc7 to
28ae901
Compare
… string This makes it easier to migrate from a particular implementation of parser and remove the need to pass in UnaryOp / BinaryOp
…nd remove `table_length` as arg
iajoiner
force-pushed
the
feat/remove-len
branch
from
28ae901 to
9e83101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
In order to make
ProofPlans composable it is necessary to allow one or moreProofPlans as the input to another. As such it is a great idea to removetable_lengthas an argument inProofPlan::result_evaluatewhich in turn requires removal inProofExpr.What changes are included in this PR?
table_lengthfromProofExpr::result_evaluateand returnColumnarValue.table_lengthfromProofPlan::result_evaluate.Are these changes tested?
Yes