refactor!: proof_of_sql_parser::intermediate_ast::ResourceId with sqlparser::ast::ObjectName in the proof-of-sql crate
#449
+1,669
−1,547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parser::ast::ObjectName in the proof-of-sql crate
2 tasks
iajoiner
reviewed
Jan 2, 2025
| /// Converts a dot-separated string into an `ObjectName`. | ||
| #[must_use] | ||
| pub fn object_name_from(s: &str) -> ObjectName { | ||
| ObjectName( |
There was a problem hiding this comment.
Why is it in the parser crate when it has nothing to do with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Part of #235
Fixes #352