[Magic] Update FixMagicIfNeeded #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function in message was missing a fix for skill points - connected to another bigger bug that I have no idea how to fix. In Multiplayer, players can be set to the level of the owner of the world due to unknown circumstances after unlocking magic. When this happens, though, the player whose level was set does not get the skill points and becomes unable to get those skill points that were skipped. Due to this, my assumption was that this was the function that was called, which is why I've added this change to at least give the players the correct amount of skill points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function in pull request is missing a fix for skill points - connected to another bigger bug that I have no idea how to fix.
In Multiplayer, players can be set to the level of the owner of the world due to unknown circumstances after unlocking magic. When this happens, though, the player whose level was set does not get the skill points and becomes unable to get those skill points that were skipped. Due to this, my assumption was that this was the function that was called, which is why I've added this change to at least give the players the correct amount of skill points.
Just as a heads up, this is untested (unsure of how to test) but it should be pretty easy to fix up if it is wrong - am a little uncertain on whether my foreach is accessing the dictionary correctly.