RushOrders 1.6 update #411
Conversation
Adds new method to replace removed Farm.getBuildingUnderConstruction and replaces all calls to the removed method with the new one.
Used the new Building.getData to replace removed BluePrint when calculating building rush price.
There is no longer a method in Utilities for getting upgrade prices, so prices have been hardcoded in.
Fixing the level-price key-value stuff
|
Oh, also, when I updated the packages for RushOrders it automatically updated those packages for the other mods that used them, it looked like. That's why so many other csproj files are changed. |
|
Oop, I figured out how to make the price values not hardcoded, one moment!! |
|
You might want to rebase & squash some of those commits ^^ |
|
Oh, also, I couldn't find a way to make Clint say the dialogue, since all DrawDialogue methods required a path to a file in the Content folder, so the dialogue is "said" by the narrator now, similar to the "You got a thing!" dialogues |
|
And each of my commits is titled to address the individual parts of the code I changed, which are all different. If I squashed them, they'd be more confusing, in my opinion, because I couldn't think of concise ways to communicate the wide variety of things they address. |
|
Yeah but 2 weeks from now, are people going to care that there were 20 partial fixes to 20 parts of RushOrders, or 1 commit that made it compatible with 1.6 ? |
|
you can just squash during the merge. no real reason to squash here. |
|
Well, there is the problem of all those extra project files in the PR... |
|
Hmm. I'll see if I can fix that, one moment. |
|
Did that fix it? Or is the changed solution file also a problem? |
|
Yeah, if you don't mind could you take that out of the PR too? |
|
Had to eat dinner first, but now it's done. |
I updated RushOrders for 1.6, tested it on my machine, and it appears to be working. Asking to merge back so others can use it too!