Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two checks with GH Actions and .mailmap #112

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

yashi
Copy link
Member

@yashi yashi commented Dec 17, 2024

This PR adds two checks (gitlint and linelint) with GitHub Actions and .mailmap to hide typos in mail address in commits.

Add .mailmap to merge typo on ".con".

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
@yashi yashi requested a review from sasataku as a code owner December 17, 2024 05:55
Add EOF newline to the linelint happy.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
GitHub only shows missing EOF newlines with a no symbol. Add linelint
to warn about it.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Add gitlint to check each and every commit on a PR.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
@yashi yashi force-pushed the add-checks-and-mailmap branch from ff2ba2e to 7983fe0 Compare December 17, 2024 06:10
Copy link
Member

@sasataku sasataku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the typo in the email address. I made the typo when replacing my PC.

@sasataku sasataku merged commit c231a0f into spacecubics:main Dec 17, 2024
44 checks passed
@yashi yashi deleted the add-checks-and-mailmap branch December 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants