Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.21 #184

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Upgrade to go 1.21 #184

merged 2 commits into from
Sep 29, 2023

Conversation

mwasilew2
Copy link
Contributor

Upgrades from 1.19 to 1.21

Signed-off-by: Michal Wasilewski <michal@mwasilewski.net>
@mwasilew2
Copy link
Contributor Author

mwasilew2 commented Sep 27, 2023

staticcheck doesn't support 1.21: https://staticcheck.io/changes/2023.1/ , that's why the lint job is failing

@mwasilew2 mwasilew2 marked this pull request as draft September 27, 2023 15:59
@tomasmik
Copy link
Contributor

staticcheck doesn't support 1.21: https://staticcheck.io/changes/2023.1/ , that's why the lint job is failing

This is quite ugly. Are there any news on when it would be supported? I kinda like the linting.

@michieldewilde
Copy link
Contributor

michieldewilde commented Sep 28, 2023

@michalg9

- name: Mark source directory as safe.
        run: git config --global --add safe.directory $GITHUB_WORKSPACE

adding this as a step after you checkout the code should solve this problem.

The error is:

-: error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping. (compile)

Staticcheck 2023.1.4 included support for go 1.21 and latest points to 2023.1.6

Signed-off-by: Michal Wasilewski <michal@mwasilewski.net>
@mwasilew2
Copy link
Contributor Author

@michieldewilde good catch!

@mwasilew2 mwasilew2 marked this pull request as ready for review September 28, 2023 16:03
@mwasilew2 mwasilew2 merged commit f6739d3 into main Sep 29, 2023
9 checks passed
@mwasilew2 mwasilew2 deleted the mwasilew2/upgrade-spacectl-to-go-121 branch September 29, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants