Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval and rejection support #82

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Add approval and rejection support #82

merged 2 commits into from
Aug 29, 2022

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Aug 26, 2022

  • Added the ability to approve and reject runs and tasks.
  • The approval and rejection mutations accept an optional run ID (if not specified they target the stack blocker). Because of that I've created an extra optional run ID flag and renamed the required one.

Here's some example usages:

# Approving the current stack blocker
stack approve --id simple-stack

# Approving a specific run with a note
stack approve --id simple-stack --run "01GBDAFEF9HFBQW3ZPV3Z38K0P" --note "LGTM"

# Rejecting the current stack blocker with a note
stack reject --id simple-stack --note "Not on my watch"

# Rejecting a specific run with no note
stack reject --id simple-stack --run "01GBDAFEF9HFBQW3ZPV3Z38K0P"

- Added the ability to approve and reject runs and tasks.
- The approval and rejection mutations accept an optional run ID (if not specified they target the stack blocker). Because of that I've created an extra optional run ID flag and renamed the required one.

Issues: #81
@adamconnelly adamconnelly merged commit ed0540b into main Aug 29, 2022
@adamconnelly adamconnelly deleted the 81-approve-reject branch August 29, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants