Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new resource spacelift_gitlab_integration #557

Merged
merged 14 commits into from
May 28, 2024
Merged

feat: new resource spacelift_gitlab_integration #557

merged 14 commits into from
May 28, 2024

Conversation

truszkowski
Copy link
Contributor

Description of the change

Origin PR

This PR contains the new resource spacelift_gitlab_integration to create an GitLab integration for a Spacelift space.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

tmeckel added 12 commits May 23, 2024 11:33
@tmeckel @truszkowski
refactor: moved CustomVCSInput and CustomVCSUpdateInput to separate p…
e258f6c 
…ackage vcs
@tmeckel @truszkowski
refactor: moved GitLab schema field name constants to gitlab_integrat…
fbd47a6 
…ion.go
@tmeckel @truszkowski
feat: implemented spacelift_gitlab_integration resource
0a3807f
@tmeckel @truszkowski
test: added tests for spacelift_gitlab_integration resource
e75e974
@tmeckel @truszkowski
docs: added examples and docs for spacelift_gitlab_integration resource
772c067
@tmeckel @truszkowski
chore: added .envrc for easier setup of environment variables from .e…
9b416ea 
…nv file
@tmeckel @truszkowski
cicd: added SPACELIFT_PROVIDER_TEST_SOURCECODE_GITLAB_DEFAULT_TOKEN a…
3381d0f 
…nd SPACELIFT_PROVIDER_TEST_SOURCECODE_GITLAB_SPACELEVEL_TOKEN to GitHub test workflows
@tmeckel @truszkowski
fix: fix typo in GraphQL query for GitLabIntegration and add ForceNew…
3611a29 
… flag to isDefault field in schema in spacelift/resource_gitlab_integration.go
@tmeckel @truszkowski
refactor: rename "webhookURL" field to "webhookUrl" in GitLabIntegrat…
1bc581f 
…ion struct and remove "Token" field
@tmeckel @truszkowski
refactor: changes to spacelift/resource_gitlab_integration.go
1e34312 
* add CustomizeDiff function ensure space is set to root if the integration should be the default
* make gitLabUserFacingHost required and removed code to derive it from gitLabAPIHost if not set
* set default value for gitLabSpaceID to "root"
@tmeckel @truszkowski
docs: updated docs for spacelift_gitlab_integration
6f25be5
@tmeckel @truszkowski
tests: updated tests for spacelift_gitlab_integration
3740d4d
@truszkowski truszkowski force-pushed the CU-8694mkqza-feat/resource-gitlab-integration branch from 1e5cbd2 to 3740d4d Compare May 23, 2024 09:36
@truszkowski truszkowski mentioned this pull request May 23, 2024
Closed
14 tasks
@truszkowski
Copy link
Contributor Author

A few tests didn't pass - the reason is gitlabIntegrationCreate isn't available for this kind of client (machine user). We'll fix that on the backend side.

@truszkowski truszkowski requested review from peterdeme and a team May 24, 2024 11:47
@truszkowski
Copy link
Contributor Author

It's fixed, but it will be available on prod next week.

adamconnelly
adamconnelly reviewed May 24, 2024
View reviewed changes
peterdeme
peterdeme reviewed May 24, 2024
View reviewed changes
@peterdeme
Copy link
Contributor

just the minor things, otherwise LGTM

@truszkowski truszkowski requested a review from a team May 27, 2024 12:16
@truszkowski truszkowski merged commit 1cfb831 into main May 28, 2024
7 checks passed
@truszkowski truszkowski deleted the CU-8694mkqza-feat/resource-gitlab-integration branch May 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamconnelly adamconnelly adamconnelly approved these changes

@peterdeme peterdeme peterdeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@truszkowski @peterdeme @adamconnelly @tmeckel