Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to spacelift_mounted_file #604

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Feb 6, 2025

Description of the change

Resolving #603

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@peterdeme peterdeme force-pushed the add-description-to-mounted-file branch from cf811f2 to 269df4d Compare February 6, 2025 14:53
@peterdeme peterdeme force-pushed the add-description-to-mounted-file branch 3 times, most recently from 1cd39a9 to 4be8d73 Compare February 7, 2025 12:33
@peterdeme peterdeme marked this pull request as ready for review February 7, 2025 13:01
@peterdeme peterdeme requested a review from a team February 7, 2025 13:02
@peterdeme peterdeme enabled auto-merge (squash) February 10, 2025 09:30
@peterdeme peterdeme force-pushed the add-description-to-mounted-file branch from 4be8d73 to 4b61106 Compare February 10, 2025 09:31
Signed-off-by: peterdeme <snypox@gmail.com>
@peterdeme peterdeme force-pushed the add-description-to-mounted-file branch from 4b61106 to e4a8350 Compare February 10, 2025 09:36
@peterdeme peterdeme merged commit 4e7286c into main Feb 10, 2025
7 checks passed
@peterdeme peterdeme deleted the add-description-to-mounted-file branch February 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants