Add limit on nesting depth for go-scale #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dshulyak
approved these changes
Jun 20, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 20, 2023
## Motivation Closes #4094. Merge after spacemeshos/go-scale#60 has been merged and released. ## Changes - Integrates go-scale with limit on nesting in types - Default max. nesting depth is 4, can be configured if more or less is better ## Test Plan - Tests added to go-scale for new functionallity. ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 20, 2023
## Motivation Closes #4094. Merge after spacemeshos/go-scale#60 has been merged and released. ## Changes - Integrates go-scale with limit on nesting in types - Default max. nesting depth is 4, can be configured if more or less is better ## Test Plan - Tests added to go-scale for new functionallity. ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 20, 2023
## Motivation Closes #4094. Merge after spacemeshos/go-scale#60 has been merged and released. ## Changes - Integrates go-scale with limit on nesting in types - Default max. nesting depth is 4, can be configured if more or less is better ## Test Plan - Tests added to go-scale for new functionallity. ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Jun 20, 2023
## Motivation Closes #4094. Merge after spacemeshos/go-scale#60 has been merged and released. ## Changes - Integrates go-scale with limit on nesting in types - Default max. nesting depth is 4, can be configured if more or less is better ## Test Plan - Tests added to go-scale for new functionallity. ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spacemeshos/go-spacemesh#4094.
This limits the depth of types encoded with scale. By default nesting more than 4 levels deep will cause an error when encoding or decoding a scale object. This is done during runtime. This limit is configurable when instantiating the Encoder or Decoder.