Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding uint pointers #85

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Encoding uint pointers #85

merged 4 commits into from
Apr 4, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Mar 30, 2024

No description provided.

@poszu poszu requested review from dshulyak and fasmat March 30, 2024 10:05
@poszu poszu changed the base branch from master to encoding-uintX-slices March 30, 2024 10:06
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 50.0%. Comparing base (34c1f26) to head (7274b99).

Files Patch % Lines
encoder.go 60.0% 8 Missing and 8 partials ⚠️
decoder.go 75.0% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #85     +/-   ##
========================================
+ Coverage    46.4%   50.0%   +3.5%     
========================================
  Files           6       6             
  Lines         811     891     +80     
========================================
+ Hits          377     446     +69     
+ Misses        378     376      -2     
- Partials       56      69     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dshulyak dshulyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really have a use case for encoding options with integers where zero integer can't be used instead?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@poszu
Copy link
Collaborator Author

poszu commented Apr 2, 2024

do you really have a use case for encoding options with integers where zero integer can't be used instead?

Yes, for example, a vrf nonce index, for which a zero value is also a valid value.

encoder_test.go Outdated Show resolved Hide resolved
Base automatically changed from encoding-uintX-slices to master April 4, 2024 09:28
@poszu poszu merged commit 704f3f2 into master Apr 4, 2024
10 checks passed
@poszu poszu deleted the encoding-uintX-pointers branch April 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants