-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP: Add Malfeasance V2 Handler and Publisher #6184
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
reviewed
Aug 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6184 +/- ##
========================================
Coverage 81.7% 81.7%
========================================
Files 312 315 +3
Lines 34613 34794 +181
========================================
+ Hits 28297 28458 +161
- Misses 4479 4496 +17
- Partials 1837 1840 +3 ☔ View full report in Codecov by Sentry. |
The contents of this PR have been integrated into #6307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds the a malfeasance handler that will be used when ATX v2 goes live.
Description
This PR simplifies the existing malfeasance handler to only handle V1 proofs (which will eventually be retired in a future release) and adds a handler for V2 proofs.
Additionally publishers for V1 and V2 proofs have been added. Shifting the responsibility for publishing proofs from the components (
activation
, etc.) to a dedicated service. This also allows to simplify handling of proof publication since the components now don't need to keep track any more if they are in sync or not before publishing a proof (the publisher now keeps track of this instead).The new DB table
malfeasance
requires foreign key constraints so these have now been enabled usingPRAGMA foreign_keys = ON;
. The new table will keep track of malicious identities and their proofs. The existingidentities
table will in future only be used to keep track of which identities belong to which marriage set and the proofs in them will be dropped with the V1 publisher / handler of malfeasance proofs. (Proofs will be migrated to V2)Test Plan
TODO