[Merged by Bors] - Update metrics use of malfeasance package #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
acud,
jellonek and
kacpersaw
as code owners
fasmat
force-pushed
the
malfeasance-metrics-v2
branch
from
403680c to
1f126b1
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6569 +/- ##
=======================================
Coverage 79.8% 79.9%
=======================================
Files 356 356
Lines 47316 47336 +20
=======================================
+ Hits 37775 37836 +61
+ Misses 7394 7360 -34
+ Partials 2147 2140 -7 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Dec 27, 2024
poszu
approved these changes
Jan 3, 2025
spacemesh-bors
bot
changed the base branch from
malfeasance-info-v2
to
develop
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
## Motivation Merge after #6566. This updates the way we handle metrics with malfeasance.
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
## Motivation Merge after #6566. This updates the way we handle metrics with malfeasance.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merge after #6566. This updates the way we handle metrics with malfeasance.
Description
Instead of passing along the metrics counter the domain specific handlers just return the labels that the malfeasance handler should use to report metrics.
Test Plan
existing tests were updated and extended
TODO