-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support certificates for registeration #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #429 +/- ##
=========================================
+ Coverage 77.1% 77.3% +0.1%
=========================================
Files 25 25
Lines 1959 2010 +51
=========================================
+ Hits 1512 1554 +42
- Misses 330 336 +6
- Partials 117 120 +3
|
poszu
force-pushed
the
support-certificates-for-submit
branch
3 times, most recently
from
November 1, 2023 08:36
cb08b00
to
9b97180
Compare
poszu
changed the title
Support certificates for registering
Support certificates for registeration
Nov 1, 2023
poszu
force-pushed
the
support-certificates-for-submit
branch
from
November 1, 2023 08:52
9b97180
to
553ec5d
Compare
fasmat
approved these changes
Nov 9, 2023
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
poszu
force-pushed
the
support-certificates-for-submit
branch
from
November 10, 2023 09:26
5d7917e
to
1284049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
There is now an alternative way to PoW of verifying if a node is allowed to register in the open round by certificate verification.
It's considered unstable now and the poet supports both ways until it is stabilized.
If a certifier is configured (an URL + a pubkey), the poet will first try to verify the certificate. If it's not provided (for example a node that didn't update tries to register) - fallback to verifying PoW. Hence a poet that wants to support certificates should configure PoW as well until the certificate way is fully stabilized.
It returns unauthorized (HTTP 401) if the certifier is configured but the certificate is not valid, allowing the node the re-certify and retry registration with a new certificate.