Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenerateProof returning an invalid proof on a short deadline #497

Merged

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 3, 2024

Changed GenerateProof to always return a valid proof if not cancelled even if it takes longer than deadline.

This allows to just pass time.Now() as deadline to the function (for instance in tests) to return the smallest valid proof.

@fasmat fasmat requested a review from poszu July 3, 2024 15:58
@fasmat fasmat self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.9%. Comparing base (ccfa5da) to head (06970d3).

Files Patch % Lines
prover/prover.go 96.6% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #497     +/-   ##
=========================================
+ Coverage     80.6%   80.9%   +0.2%     
=========================================
  Files           27      27             
  Lines         1743    1768     +25     
=========================================
+ Hits          1406    1431     +25     
  Misses         216     216             
  Partials       121     121             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat force-pushed the fix-generate-proof-returning-invalid-proof-short-deadline branch from 59e40d8 to e489df1 Compare July 3, 2024 16:16
@fasmat fasmat force-pushed the fix-generate-proof-returning-invalid-proof-short-deadline branch from 23e3c4c to 06970d3 Compare July 3, 2024 16:37
@fasmat fasmat added this pull request to the merge queue Jul 3, 2024
Merged via the queue into develop with commit b7118d1 Jul 3, 2024
9 checks passed
@fasmat fasmat deleted the fix-generate-proof-returning-invalid-proof-short-deadline branch July 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants