fix: download in case when url file was dropped or any exist() error #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Jul 16, 2024
| @@ -91,7 +91,7 @@ fn go_spacemesh_default_path() -> &'static str { | |||
| } | |||
|
|
|||
| fn backup_or_fail(file_path: &PathBuf) -> () { | |||
| if file_path.exists() { | |||
| if file_path.try_exists().unwrap_or(false) { | |||
There was a problem hiding this comment.
I'm not sure it's a good idea to unwrap Err to false. An error could mean a lack of permissions (https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.try_exists). In such a situation, it's probably best to fail and to advice the user to verify rather than just not back the files up. Wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some edge-cases which produces bugs, like this one:
