Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not skip backup in case of error + remove state.url as the last step #19

Merged
merged 4 commits into from
Jul 18, 2024

chore: apply @poszu remarks

c2e6ac6
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix: do not skip backup in case of error + remove state.url as the last step #19

chore: apply @poszu remarks
c2e6ac6
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 16, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 159 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/main.rs:159:38
    |
159 |         let go_version = get_version(&go_path_str)?;
    |                                      ^^^^^^^^^^^^ help: change this to: `go_path_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 144 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> src/main.rs:144:13
    |
144 |             return Ok::<i32, anyhow::Error>(0);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
144 -             return Ok::<i32, anyhow::Error>(0);
144 +             Ok::<i32, anyhow::Error>(0)
    |

Check warning on line 84 in src/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/utils.rs:84:23
   |
84 |   let url = build_url(&download_url, &path);
   |                       ^^^^^^^^^^^^^ help: change this to: `download_url`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 19 in src/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

file opened with `create`, but `truncate` behavior not defined

warning: file opened with `create`, but `truncate` behavior not defined
  --> src/download.rs:19:6
   |
19 |     .create(true)
   |      ^^^^^^^^^^^^- help: add: `.truncate(true)`
   |
   = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
   = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
   = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
   = note: `#[warn(clippy::suspicious_open_options)]` on by default