added install script #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffrr
reviewed
Mar 4, 2025
install.sh
Outdated
| local reload_needed=false | ||
|
|
||
| # Detect shell configuration file | ||
| if [ -n "${ZSH_VERSION-}" ]; then |
There was a problem hiding this comment.
$ZSH_VERSION is only set when you're actually running zsh as your interactive shell but the script executes in sh/bash env. Maybe use $SHELL (returns /bin/zsh for me) or just check if its macos.
install.sh
Outdated
|
|
||
| # Reload shell if needed | ||
| if [ "$reload_status" = "reload" ]; then | ||
| if [ -n "${ZSH_VERSION-}" ]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an install script for quick install.